we are now treating the explain as json, so lets actually test it as …

…such!
o19s · Sep 6, 2023 · 39ff7e0 · 39ff7e0
1 parent fc92897
commit 39ff7e0
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/app/views/api/v1/snapshots/_snapshot.json.jbuilder b/app/views/api/v1/snapshots/_snapshot.json.jbuilder
@@ -15,11 +15,11 @@ if with_docs
   json.docs do
     snapshot.snapshot_queries.each do |snapshot_query|
       docs = snapshot_query.snapshot_docs.map do |doc|
-        { 
-          id: doc.doc_id, 
-          explain: JSON.parse(doc.explain), 
+        {
+          id:         doc.doc_id,
+          explain:    JSON.parse(doc.explain),
           rated_only: doc.rated_only,
-          fields: doc.fields.blank? ? nil :JSON.parse(doc.fields)
+          fields:     doc.fields.blank? ? nil : JSON.parse(doc.fields),
         }
       end
 

diff --git a/test/controllers/api/v1/snapshots_controller_test.rb b/test/controllers/api/v1/snapshots_controller_test.rb
@@ -24,12 +24,12 @@ class SnapshotsControllerTest < ActionController::TestCase
               name:    'New Snapshot',
               docs:    {
                 first_query.id  => [
-                  { id: 'doc1', explain: '1' },
-                  { id: 'doc2', explain: '2' }
+                  { id: 'doc1', explain: 1 },
+                  { id: 'doc2', explain: 2 }
                 ],
                 second_query.id => [
-                  { id: 'doc3', explain: '3' },
-                  { id: 'doc4', explain: '4' }
+                  { id: 'doc3', explain: 3 },
+                  { id: 'doc4', explain: 4 }
                 ],
               },
               queries: {
@@ -79,8 +79,8 @@ class SnapshotsControllerTest < ActionController::TestCase
               name:    'New Snapshot',
               docs:    {
                 first_query.id  => [
-                  { id: 'doc1', explain: '1' },
-                  { id: 'doc2', explain: '2' }
+                  { id: 'doc1', explain: 1 },
+                  { id: 'doc2', explain: 2 }
                 ],
                 # in Rails 4, we could do second_query.id => [] and getting the second_query in,
                 # but in Rails 5, the second_query doesn't show up because the array that is empty
@@ -107,8 +107,8 @@ class SnapshotsControllerTest < ActionController::TestCase
 
             snapshot = response.parsed_body
 
-            assert_equal snapshot['name'],        data[:snapshot][:name]
-            assert_equal snapshot['docs'].length, data[:snapshot][:docs].length
+            assert_equal data[:snapshot][:name],        snapshot['name']
+            assert_equal data[:snapshot][:docs].length, snapshot['docs'].length
 
             data_doc      = data[:snapshot][:docs][first_query.id][0]
             response_doc  = snapshot['docs'][first_query.id.to_s][0]
@@ -148,12 +148,12 @@ class SnapshotsControllerTest < ActionController::TestCase
               name:    '',
               docs:    {
                 first_query.id  => [
-                  { id: 'doc1', explain: '1' },
-                  { id: 'doc2', explain: '2' }
+                  { id: 'doc1', explain: 1 },
+                  { id: 'doc2', explain: 2 }
                 ],
                 second_query.id => [
-                  { id: 'doc3', explain: '3' },
-                  { id: 'doc4', explain: '4' }
+                  { id: 'doc3', explain: 3 },
+                  { id: 'doc4', explain: 4 }
                 ],
               },
               queries: {
@@ -181,12 +181,12 @@ class SnapshotsControllerTest < ActionController::TestCase
             snapshot: {
               docs:    {
                 first_query.id  => [
-                  { id: 'doc1', explain: '1' },
-                  { id: 'doc2', explain: '2' }
+                  { id: 'doc1', explain: 1 },
+                  { id: 'doc2', explain: 2 }
                 ],
                 second_query.id => [
-                  { id: 'doc3', explain: '3' },
-                  { id: 'doc4', explain: '4' }
+                  { id: 'doc3', explain: 3 },
+                  { id: 'doc4', explain: 4 }
                 ],
               },
               queries: {

diff --git a/test/fixtures/snapshot_docs.yml b/test/fixtures/snapshot_docs.yml
@@ -23,22 +23,22 @@ a_doc:
   doc_id:         "doc a"
   position:       1
   snapshot_query: :first_snapshot_query
-  explain:        "Explain Me"
+  explain:        '{"message": "Explain Me"}'
 
 b_doc:
   doc_id:         "doc b"
   position:       1
   snapshot_query: :first_snapshot_query
-  explain:        "Explain Me"
+  explain:        '{"message": "Explain Me"}'
 
 c_doc:
   doc_id:         "doc c"
   position:       1
   snapshot_query: :second_snapshot_query
-  explain:        "Explain Me"
+  explain:        '{"message": "Explain Me"}'
 
 d_doc:
   doc_id:         "doc d"
   position:       1
   snapshot_query: :second_snapshot_query
-  explain:        "Explain Me"
+  explain:        '{"message": "Explain Me"}'