Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the Svelte 5 env. #701

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Support for the Svelte 5 env. #701

merged 4 commits into from
Oct 23, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Oct 23, 2024

  • Svelte 5 support;
  • Tests;
  • Changelog.

Closes #700

@shimkiv shimkiv requested a review from ymekuria October 23, 2024 11:53
@shimkiv shimkiv self-assigned this Oct 23, 2024
@shimkiv shimkiv requested review from boray and 45930 October 23, 2024 11:53
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8cdcac3) to head (7d2602d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #701   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1475      1475           
  Branches       300       300           
=========================================
  Hits          1475      1475           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shimkiv
Copy link
Member Author

shimkiv commented Oct 23, 2024

Nightly workflow execution results for this branch: https://github.com/o1-labs/zkapp-cli/actions/runs/11479567429

@shimkiv shimkiv marked this pull request as ready for review October 23, 2024 12:12
@shimkiv shimkiv requested a review from Trivo25 October 23, 2024 14:28
@shimkiv shimkiv merged commit e30f712 into main Oct 23, 2024
18 checks passed
@shimkiv shimkiv deleted the feat/svelte5-support branch October 23, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the project scaffold for Svelte 5 (or explicitly stay with Svelte 4 while work on the v5 support)
3 participants