Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiring the o1VM Proof struct into the Mina OCaml codebase. #2749

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −2
Draft

Wiring the o1VM Proof struct into the Mina OCaml codebase. #2749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8519a45
Wiring the o1VM struct into the Mina OCaml codebase.
shimkiv Nov 5, 2024
037f06e
Use ocaml_gen::CustomType.
shimkiv Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions o1vm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ark-bn254.workspace = true
# FIXME: Only activate this when legacy_o1vm is built
folding.workspace = true
# FIXME: Only activate this when legacy_o1vm is built
kimchi = { workspace = true, features = [ "bn254" ] }
kimchi = { workspace = true, features = ["bn254"] }
kimchi-msm.workspace = true
poly-commitment.workspace = true
groupmap.workspace = true
Expand Down Expand Up @@ -62,4 +62,10 @@ libc.workspace = true
rayon.workspace = true
sha3.workspace = true
itertools.workspace = true
thiserror.workspace = true
thiserror.workspace = true

ocaml = { workspace = true, optional = true }
ocaml-gen = { workspace = true, optional = true }

[features]
ocaml_types = ["ocaml", "ocaml-gen"]
4 changes: 4 additions & 0 deletions o1vm/src/pickles/proof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ impl<G: KimchiCurve> ProofInputs<G> {
}

// FIXME: should we blind the commitment?
#[cfg_attr(
feature = "ocaml_types",
derive(ocaml::IntoValue, ocaml::FromValue, ocaml_gen::CustomType)
)]
pub struct Proof<G: KimchiCurve> {
pub commitments: WitnessColumns<PolyComm<G>, [PolyComm<G>; N_MIPS_SEL_COLS]>,
pub zeta_evaluations: WitnessColumns<G::ScalarField, [G::ScalarField; N_MIPS_SEL_COLS]>,
Expand Down
Loading