Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mina_curves: activating ADX instructions by default #2617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Sep 25, 2024

Spotted by @sebastiencs.

ADX instructions are not activated otherwise. However, this change activates it all the time, and compiling on machines not supporting ADX will fail. Is it what we want?

If approved, I can backport on develop and benchmark on Mina compatible.

cc @tizoc

@tizoc
Copy link
Contributor

tizoc commented Sep 25, 2024

https://docs.minaprotocol.com/berkeley-upgrade/requirements says AVX here but probably meant to say ADX

@dannywillems
Copy link
Member Author

Reg Mina: it seems we build by default with the flags: https://github.com/MinaProtocol/mina/blob/develop/src/lib/crypto/kimchi_bindings/stubs/dune#L59 (and https://github.com/MinaProtocol/mina/blob/compatible/src/lib/crypto/kimchi_bindings/stubs/dune#L13), therefore we should not expect any change in Mina?

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.16%. Comparing base (46d7cf8) to head (df85c17).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2617   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files         244      244           
  Lines       57658    57658           
=======================================
+ Hits        41033    41034    +1     
+ Misses      16625    16624    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -19,3 +19,7 @@ rand.workspace = true
ark-algebra-test-templates.workspace = true
ark-std.workspace = true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ark-std need to be moved from dev-dependencies to dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants