Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mina_poseidon: bench poseidon block cipher [master] #2399

Merged
merged 2 commits into from
Jul 9, 2024
Merged

mina_poseidon: bench poseidon block cipher [master] #2399

merged 2 commits into from
Jul 9, 2024

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Jul 8, 2024 •
edited
Loading

Will be used later to bench #2394.

Output on my machine of cargo bench:

poseidon_absorb_permutation kimchi                                                                             
                        time:   [50.202 µs 50.240 µs 50.309 µs]
Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe

poseidon_absorb_permutation legacy                                                                            
                        time:   [52.858 µs 52.875 µs 52.894 µs]
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe

@dannywillems dannywillems changed the title mina_poseidon: bench poseidon block cipher mina_poseidon: bench poseidon block cipher [master] Jul 8, 2024
@dannywillems dannywillems mentioned this pull request Jul 8, 2024
Draft
volhovm
volhovm approved these changes Jul 9, 2024
View reviewed changes
poseidon/benches/poseidon.rs
use mina_curves::pasta::Fp;

pub fn bench_poseidon_absorb_permutation_pasta_fp(c: &mut Criterion) {
// FIXME: use o1_utils test rng
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but why wasn't it possible?..

@volhovm volhovm merged commit bb0c15f into master Jul 9, 2024
7 checks passed
@volhovm volhovm deleted the dw/bench-poseidon-master branch July 9, 2024 12:33
@dannywillems dannywillems mentioned this pull request Jul 9, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volhovm volhovm volhovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannywillems @volhovm