Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the DocNodeView in a ChildDescriptorContext. #116

Merged
merged 3 commits into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. Wrap the DocNodeView in a ChildDescriptorContext.

    When rendering nested ProseMirror editors, e.g.
    when taking control over an atom node's content,
    the nested DocNodeView would register itself as
    the child of the atom node in the view descriptor
    tree. This could cause subtle issues when, e.g.,
    ProseMirror attempts to determine whether the
    content is ltr or rtl, because it would treat the
    nested editor as the contentDOM of the atom, even
    if it was rendered in a portal into a non-
    contiguous part of the page. Presumably other
    issues could also arise from the fact that
    ProseMirror thought this node had a contentDOM
    when it actually does not.
    
    This PR resolves this by simply providing a top-
    level ChildDescriptorContext, so that nested
    editors never accidentally cross the boundary up
    into their parents' view descriptor tree.
    smoores-dev committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    aa24860 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    142bbf1 View commit details
    Browse the repository at this point in the history
  3. Remove dist files again

    smoores-dev committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0a3651e View commit details
    Browse the repository at this point in the history