Add support for native ProseMirror widget decorations #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new component type,
NativeWidgetView
, that renderstoDOM
-style ProseMirror widget decorations within a wrapperspan
. Added the gapcursor and tables plugins to the demo for testing (both rely on widgets). This ended up being pleasantly simple, I think!In testing with the tables plugin, I found and resolved two more issues:
flushSync
rather thanbatch
indispatchTransaction
. I don't remember why we initially switched tobatch
here, but we need to flush state updates all of the way through to the render function of theuseEditor
hook on eachview.dispatch
, so thatview.state
gets updated in time for the next call toview.dispatch
.