fix: support custom url protocol scheme on websockets #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmnaid
reviewed
Feb 28, 2024
| }) | ||
| ); | ||
| let connection; | ||
| if (!window.location.protocol.includes('http')) { |
There was a problem hiding this comment.
If you're https then the .includes will also match with https
There was a problem hiding this comment.
const protocol = 'https:'
protocol.includes('http') --> true
There was a problem hiding this comment.
For security, should we just have includes http OR https instead of keeping it open to any value with http?
kmnaid
approved these changes
Feb 28, 2024
delambo
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom url protocol schemes are not supported in sockjs, this allows you to render kyt-generated content locally in custom URL patterns by using a web-socket connection instead.