Skip to content

Commit

Permalink
Merge branch 'release/2.4.39' into craft-webpack
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew Welch committed Jun 11, 2021
2 parents 03221f3 + 47425c5 commit 49d9279
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 33 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# nystudio107/craft Change Log

## 2.4.39 - 2021.06.11
### Changed
* Removed whitelist settings in `tailwind.conf.js`
* Cleaned up the `php-dev-craft` & `php-prod-craft` Dockerfile file permissions

## 2.4.38 - 2021.05.23
### Changed
* Run php container as the `www-data` user to avoid permissions issues
Expand Down
3 changes: 0 additions & 3 deletions buildchain/tailwind.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ module.exports = {
],
mode: 'layers',
options: {
whitelist: [
'../src/css/components/**/*.{css}',
],
}
},
theme: {
Expand Down
3 changes: 2 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ services:
volumes: &php-volumes
- cpresources:/var/www/project/cms/web/cpresources:delegated
- storage:/var/www/project/cms/storage:delegated
- ./cms:/var/www/project/cms:cached
# Specific directories that need to be bind-mounted
- ./cms/storage/logs:/var/www/project/cms/storage/logs:delegated
- ./cms/storage/runtime/compiled_templates:/var/www/project/cms/storage/runtime/compiled_templates:delegated
- ./cms:/var/www/project/cms:cached
- ./cms/vendor:/var/www/project/cms/vendor:delegated
# php - run php-fpm with xdebug
php_xdebug:
Expand Down
13 changes: 5 additions & 8 deletions docker-config/php-dev-craft/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,11 @@ RUN set -eux; \

WORKDIR /var/www/project

# Create the storage directory and make it writeable by PHP
RUN mkdir -p /var/www/project/cms/storage && \
mkdir -p /var/www/project/cms/storage/runtime && \
chown -R www-data:www-data /var/www/project/cms/storage

# Create the cpresources directory and make it writeable by PHP
RUN mkdir -p /var/www/project/cms/web/cpresources && \
chown -R www-data:www-data /var/www/project/cms/web/cpresources
RUN mkdir -p /var/www/project/cms/storage \
&& \
mkdir -p /var/www/project/cms/web/cpresources \
&& \
chown -R www-data:www-data /var/www/project

WORKDIR /var/www/project/cms

Expand Down
28 changes: 7 additions & 21 deletions docker-config/php-prod-craft/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,13 @@ RUN set -eux; \
WORKDIR /var/www/project

COPY ./run_queue.sh .
RUN chmod a+x run_queue.sh

# Create the storage directory and make it writeable by PHP
RUN mkdir -p /var/www/project/cms/storage && \
mkdir -p /var/www/project/cms/storage/runtime && \
chown -R www-data:www-data /var/www/project/cms/storage

# Create the cpresources directory and make it writeable by PHP
RUN mkdir -p /var/www/project/cms/web/cpresources && \
chown -R www-data:www-data /var/www/project/cms/web/cpresources

# Permissions
RUN chown -R www-data:www-data /var/www/project/cms/web
RUN chmod a+x run_queue.sh \
&& \
mkdir -p /var/www/project/cms/storage \
&& \
mkdir -p /var/www/project/cms/web/cpresources \
&& \
chown -R www-data:www-data /var/www/project

WORKDIR /var/www/project/cms

Expand All @@ -75,14 +69,6 @@ USER www-data
# but saves far more time in not having to deal with out of sync versions
# when working with teams or multiple environments
CMD composer install --verbose --no-progress --no-scripts --optimize-autoloader --no-interaction \
&& \
chown -R www-data:www-data /var/www/project/cms/config \
&& \
chown -R www-data:www-data /var/www/project/cms/storage \
&& \
chown -R www-data:www-data /var/www/project/cms/vendor \
&& \
chown -R www-data:www-data /var/www/project/cms/web \
&& \
composer craft-update \
&& \
Expand Down

0 comments on commit 49d9279

Please sign in to comment.