Merge pull request #275 from nxt-dev/touch_up

Touch ups

nxt_editor/dockwidgets/code_editor.py

@@ -334,7 +334,7 @@ def update_editor(self, node_list=()):
             self.setEnabled(True)
             if self.editing_active:
                 return
-            if not self.stage_model.comp_layer.node_exists(self.node_path):
+            if not self.stage_model.node_exists(self.node_path):
                 self.editor.clear()
                 return
             self.update_code_is_local()

nxt_editor/dockwidgets/property_editor.py

@@ -546,9 +546,9 @@ def set_represented_node(self):
                 order = QtCore.Qt.DescendingOrder
             col = self.user_sort_pref['column']
             if self.model.rowCount(self):
-                self.model.horizontal_header.blockSignals(True)
-                self.model.horizontal_header.setSortIndicator(col, order)
-                self.model.horizontal_header.blockSignals(False)
+                self.table_view.horizontalHeader().blockSignals(True)
+                self.table_view.horizontalHeader().setSortIndicator(col, order)
+                self.table_view.horizontalHeader().blockSignals(False)
 
         self.node_name = nxt_path.node_name_from_node_path(self.node_path)
         if not self.node_name:
@@ -1553,10 +1553,7 @@ def paint(self, painter, option, index):
         inner_rect = inner_rect.marginsRemoved(QtCore.QMargins(1, 1, 1, 1))
         painter.setPen(QtCore.Qt.NoPen)
         painter.setBrush(option.backgroundBrush)
-        attr_name = index.sibling(index.row(), COLUMNS.name).data()
-        model = index.model().sourceModel()
-        color = model.node_attr_draw_details[attr_name]['color']
-        color = QtGui.QColor(color)
+        color = index.data(role=QtCore.Qt.ForegroundRole)
         painter.setPen(color)
         if option.state & QtWidgets.QStyle.State_MouseOver:
             if self.parent.mouse_pressed == index.column():

nxt_editor/main_window.py

@@ -8,6 +8,7 @@
 import webbrowser
 from functools import partial
 import time
+import tempfile
 
 # External
 from Qt import QtWidgets
@@ -1252,6 +1253,8 @@ def __init__(self, parent=None):
         # Help Menu
         self.help_menu = self.addMenu('Help')
         self.help_menu.setTearOffEnabled(True)
+        logs_dir_action = self.help_menu.addAction('Open Logs Dir')
+        logs_dir_action.triggered.connect(self.open_logs_dir)
         prefs_dir_action = self.help_menu.addAction('Open Prefs Dir')
         prefs_dir_action.triggered.connect(self.open_prefs_dir)
         config_dir_action = self.help_menu.addAction('Open Plugins Dir')
@@ -1335,29 +1338,26 @@ def window_action_triggered(self, action=None):
 
     @staticmethod
     def open_prefs_dir():
-        d = user_dir.PREF_DIR
-        if 'darwin' in sys.platform:
-            os.system('open {}'.format(d))
-        elif 'win' in sys.platform:
-            os.startfile(d)
-        else:
-            try:
-                os.system('xdg-open {}'.format(d))
-            except:
-                logger.exception('Failed to open user dir')
+        QtGui.QDesktopServices.openUrl(
+            QtCore.QUrl.fromLocalFile(user_dir.PREF_DIR)
+        )
 
     @staticmethod
     def open_plugins_dir():
-        d = USER_PLUGIN_DIR
-        if 'darwin' in sys.platform:
-            os.system('open {}'.format(d))
-        elif 'win' in sys.platform:
-            os.startfile(d)
-        else:
-            try:
-                os.system('xdg-open {}'.format(d))
-            except:
-                logger.exception('Failed to open user config dir')
+        QtGui.QDesktopServices.openUrl(
+            QtCore.QUrl.fromLocalFile(USER_PLUGIN_DIR)
+        )
+
+    @staticmethod
+    def open_logs_dir():
+        try:
+            log_dir = nxt_log.LOG_DIR
+        except AttributeError:
+            # Guess the log dir if nxt core is old.
+            log_dir = os.path.join(tempfile.gettempdir(), 'nxt_logs')
+        QtGui.QDesktopServices.openUrl(
+            QtCore.QUrl.fromLocalFile(log_dir)
+        )
 
     def about_message(self):
         text = ('nxt {} \n'

nxt_editor/node_graphics_item.py

@@ -452,7 +452,8 @@ def draw_title(self, painter, lod=1.):
 
         # draw collapse state arrow
         for arrow in self.collapse_arrows:
-            self.scene().removeItem(arrow)
+            if arrow.scene():
+                self.scene().removeItem(arrow)
         if lod > MIN_LOD:
             self.collapse_arrows = []
             # TODO calculation needed arrows should be done outside drawing

nxt_editor/stage_view.py

@@ -1281,7 +1281,8 @@ def remove_node_graphic(self, node_path):
         self.remove_node_connection_graphics(node_path)
 
         def handle_del():
-            self.scene().removeItem(graphic)
+            if graphic.scene():
+                self.scene().removeItem(graphic)
 
         graphic.out_anim_group.finished.connect(handle_del)
         graphic.anim_out()