Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: partial fixes never applying #180

Closed
wants to merge 1 commit into from
Closed

fix: partial fixes never applying #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [Unreleased]

- Write your updates here !
- Fix partial fixes never applying due to [npm-groovy-lint](https://www.npmjs.com/package/npm-groovy-lint) v10.0.0 breaking change.

## [2.0.0] 2022-08-13

Expand Down
6 changes: 4 additions & 2 deletions server/src/linter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ export async function executeLinter(textDocument: TextDocument, docManager: Docu
returnrules: docManager.getRuleDescriptions().size > 0 ? false : true,
insight: ((settings?.insight?.enable) ? true : false),
output: 'none',
verbose: settings.basic.verbose
verbose: settings.basic.verbose,
failon: 'none'
};

const npmGroovyLintExecParam: any = {};
Expand Down Expand Up @@ -397,7 +398,8 @@ async function manageFixSourceBeforeCallingLinter(source: string, textDocument:
const textDocumentFilePath: string = URI.parse(textDocument.uri).fsPath;
const tmpLinter = new NpmGroovyLint({
sourcefilepath: textDocumentFilePath,
output: 'none'
output: 'none',
failon: 'none'
}, {});
const tmpStartPath = path.dirname(textDocumentFilePath);
let tmpConfigFilePath: string = await tmpLinter.getConfigFilePath(tmpStartPath);
Expand Down
Loading