Update dependency which to v4 - autoclosed

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
which	^2.0.2 -> ^4.0.0

---

Release Notes

npm/node-which (which)

v4.0.0

Compare Source

⚠️ BREAKING CHANGES

• support for node 14 has been removed

Bug Fixes

• c7122cd #​105 drop node14 support (@​wraithgar)
• 0083d3c #​105 update for breaking isexe api (@​wraithgar)
• 00b5cda #​106 replace reduce with flatMap (#​106) (@​green961)

Dependencies

• 22d1c84 #​105 Bump isexe from 2.0.0 to 3.1.1

v3.0.1

Compare Source

Bug Fixes

• c3a543e #​100 check lower case extensions in windows (#​100) (@​wraithgar)

Documentation

• ba58b51 #​97 Replace binary which with node-which in README.md (#​97) (@​DevDengChao)

v3.0.0

Compare Source

⚠️ BREAKING CHANGES

• refactored with the following breaking changes
  • callback has been removed from the async interface, it is now
    Promise only
  • which is now compatible with the following semver range for node:
    `^14.17.0 || ^16.13.0 || >=18.0.0
  • cli now ignores any arguments after --

Features

• 8b0187c add @​npmcli/template-oss and modernize (#​86) (@​lukekarrys)

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[github-actions]

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ DOCKERFILE	hadolint	1		0	0.08s
✅ GROOVY	npm-groovy-lint	10	2	0	20.44s
✅ JAVASCRIPT	prettier	98	98	0	3.7s
✅ JSON	jsonlint	8		0	0.2s
✅ JSON	npm-package-json-lint	yes		no	0.47s
✅ JSON	prettier	8	3	0	0.76s
✅ JSON	v8r	8		0	17.49s
✅ MARKDOWN	markdownlint	7	2	0	3.5s
✅ MARKDOWN	markdown-table-formatter	7	5	0	0.57s
✅ REPOSITORY	checkov	yes		no	16.34s
✅ REPOSITORY	gitleaks	yes		no	4.98s
✅ REPOSITORY	git_diff	yes		no	0.21s
✅ REPOSITORY	grype	yes		no	15.73s
✅ REPOSITORY	secretlint	yes		no	1.51s
✅ REPOSITORY	trivy	yes		no	9.27s
✅ REPOSITORY	trivy-sbom	yes		no	1.11s
✅ REPOSITORY	trufflehog	yes		no	7.34s
✅ SPELL	cspell	129		0	5.71s
❌ SPELL	lychee	18		1	2.12s
✅ XML	xmllint	1	0	0	0.11s
✅ YAML	prettier	3	0	0	0.65s
✅ YAML	v8r	3		0	8.47s
✅ YAML	yamllint	3		0	0.49s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[nvuillam]

@stevenh I'm kind of lost here :(

When i run npm run dev:pre-commit or even when I download the artifact from failing update job, it always fail...

Do you have a clue about how to solve it ?

Many thanks :)

Note: I merged other PRs that had all test job in success except Ùpdate check`, but I did not release a new version, not even a beta :)

[stevenh]

I will hopefully have a look some time this weekend.

[stevenh]

Looks like the latest version of node has a different version zip, so you need to make sure your local version of node is the same as its using in CI, specifically v18.20.4.

Steps to fix, depending upon your environment should be:

nvm install lts/hydrogen
npm ci
npm link
npm run dev:pre-commit

If you then run a git diff, you should see that lib/java/CodeNarcServer.jar has changed:

git diff
diff --git a/lib/java/CodeNarcServer.jar b/lib/java/CodeNarcServer.jar
index cc0d44a..661864a 100644
Binary files a/lib/java/CodeNarcServer.jar and b/lib/java/CodeNarcServer.jar differ

Just commit the change and you should be good.