Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change logback default config file to avoid logback.log at the root #352

Closed
wants to merge 6 commits into from

Conversation

nvuillam
Copy link
Owner

@nvuillam nvuillam commented Jan 7, 2024

Copy link

github-actions bot commented Jan 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ DOCKERFILE hadolint 1 0 0.07s
✅ GROOVY npm-groovy-lint 10 2 0 20.69s
✅ JAVASCRIPT eslint 100 0 0 4.42s
✅ JAVASCRIPT prettier 100 100 0 5.07s
✅ JSON eslint-plugin-jsonc 9 0 0 1.82s
✅ JSON jsonlint 9 0 0.5s
✅ JSON npm-package-json-lint yes no 0.64s
✅ JSON prettier 9 2 0 1.52s
✅ JSON v8r 9 0 8.0s
✅ MARKDOWN markdownlint 7 2 0 4.35s
✅ MARKDOWN markdown-link-check 7 0 1.56s
✅ MARKDOWN markdown-table-formatter 7 2 0 0.97s
✅ REPOSITORY checkov yes no 13.56s
✅ REPOSITORY gitleaks yes no 7.39s
✅ REPOSITORY git_diff yes no 0.41s
✅ REPOSITORY grype yes no 13.95s
✅ REPOSITORY secretlint yes no 2.79s
✅ REPOSITORY trivy yes no 5.51s
✅ REPOSITORY trivy-sbom yes no 4.81s
✅ REPOSITORY trufflehog yes no 10.64s
✅ SPELL cspell 132 0 9.37s
✅ SPELL lychee 19 0 15.71s
✅ XML xmllint 1 0 0 0.09s
✅ YAML prettier 3 0 0 0.68s
✅ YAML v8r 3 0 8.99s
✅ YAML yamllint 3 0 0.26s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Owner Author

nvuillam commented Jan 7, 2024

@stevenh I build CodeNarcServer using npm run dev:pre-commit on Windows, but the update check fails anyway, do you have a hint about how to to pass it ?

@stevenh
Copy link
Collaborator

stevenh commented Jan 8, 2024

My guess would be you have an old version of node which means your zip implementation is creating differently compress output as detailed here: https://github.com/nvuillam/npm-groovy-lint/blob/main/CONTRIBUTING.md#troubleshooting.

For the log file issue I already posted #353

@stevenh
Copy link
Collaborator

stevenh commented Jan 9, 2024

The current version of 18 on github actions is v18.19.0

@nvuillam nvuillam closed this Jan 15, 2024
@stevenh stevenh deleted the fixes/logback.log branch January 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants