Migrate from plenary to nvim_win_open #158
Conversation
lua/spectre/ui.lua
Outdated
| height = win_height + 2, | ||
| col = 4, | ||
| row = 4, | ||
| border = { "╭", "─", "╮", "│", "╯", "─", "╰", "│" } |
There was a problem hiding this comment.
| border = { "╭", "─", "╮", "│", "╯", "─", "╰", "│" } | |
| border = "rounded" |
lua/spectre/ui.lua
Outdated
| api.nvim_buf_set_lines(bufnr, 0, -1, true, content) | ||
|
|
||
| local help_win = vim.api.nvim_open_win(bufnr, true, { | ||
| title = title, |
There was a problem hiding this comment.
imo it looks a lot better with padding
| title = title, | |
| title = " " .. title .. " ", |
lua/spectre/ui.lua
Outdated
| col = 4, | ||
| row = 4, |
There was a problem hiding this comment.
This positioning is more consistent with lsp hover:
| col = 4, | |
| row = 4, | |
| col = 0, | |
| row = 1, |
lua/spectre/ui.lua
Outdated
| width = win_width + 3, | ||
| height = win_height + 2, |
There was a problem hiding this comment.
opinionated, but I don't think there should be additional right/bottom padding
| width = win_width + 3, | |
| height = win_height + 2, | |
| width = win_width, | |
| height = win_height, |
lua/spectre/ui.lua
Outdated
| api.nvim_buf_set_lines(bufnr, 0, -1, true, content) | ||
|
|
||
| local help_win = vim.api.nvim_open_win(bufnr, true, { | ||
| title = title, |
There was a problem hiding this comment.
This disables line number and relative line number, among other options
| title = title, | |
| style = "minimal", | |
| title = title, |
lua/spectre/ui.lua
Outdated
| }) | ||
| api.nvim_win_set_option(help_win, 'winblend', 0) | ||
| api.nvim_win_set_option(help_win, 'number', false) |
There was a problem hiding this comment.
unecessary when setting style = "minimal"
| api.nvim_win_set_option(help_win, 'number', false) |
lua/spectre/ui.lua
Outdated
| border = true, | ||
| borderchars ={ "─", "│", "─", "│", "╭", "╮", "╯", "╰" }, | ||
|
|
||
| local check = false |
There was a problem hiding this comment.
unused variable
| local check = false |
lua/spectre/ui.lua
Outdated
| api.nvim_buf_set_option(bufnr, "bufhidden", "wipe") | ||
| api.nvim_buf_set_lines(bufnr, 0, -1, true, content) | ||
|
|
||
| local help_win = vim.api.nvim_open_win(bufnr, true, { |
There was a problem hiding this comment.
I don't think we should automatically enter the help window, imo it should be similar to lsp hover where the window is first displayed, then hitting the keymap again enters it
| local help_win = vim.api.nvim_open_win(bufnr, true, { | |
| local help_win = vim.api.nvim_open_win(bufnr, false, { |
| api.nvim_create_autocmd({ | ||
| 'CursorMoved', | ||
| 'CursorMovedI', |
There was a problem hiding this comment.
These should be added back to close the window if we disable automatically entering the help window (vim.api.nvim_open_win(bufnr, false...)
| 'CursorMovedI', | |
| 'CursorMoved', | |
| 'CursorMovedI', | |
| 'BufHidden', | |
| 'BufLeave', | |
| 'InsertEnter', | |
| 'WinScrolled', | |
| 'BufDelete', |
There was a problem hiding this comment.
It won't work if it focus on window. I will add it back so it won't focus on it.
|
@Subjective what about now? |
|
@EpsilonKu LGTM! |
No description provided.