Upgrade to GXF 4.1 compatible gxf-mm extensions #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arun Patole <[email protected]>
tbirdso
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Looks good! Tested with v2.6.0 release candidate as below, verified this addresses previously observed extension mismatch, no further issues:
./dev_container build_and_run h264_endoscopy_tool_tracking --docker_file applications/h264/Dockerfile --language cpp --base_img <v2.6.0 rc image path>
# App runs and displays as expected./dev_container launch --img holohub:h264_endoscopy_tool_tracking
./run build h264_endoscopy_tool_tracking --configure-args "-DBUILD_TESTING:BOOL=ON"
cd build/h264_endoscopy_tool_tracking
xvfb-run -a ctest -C Release # cpp and python tests pass
Will wait for v2.6.0 release to merge.
|
Thanks @tbirdso for the review! |
mocsharp
reviewed
Oct 24, 2024
| @@ -38,12 +38,12 @@ gxf_mm_extensions=(["decoderio"]="45081ccb-982e-4946-96f9-0d684f2cfbd0" \ | |||
| ["encoder"]="ea5c44e4-15db-4448-a3a6-f32004303338") | |||
| mkdir -p gxf-mm | |||
| mkdir -p ${HOLOSCAN_LIBS_DIR} | |||
| CUDA_VERSION=12.2 | |||
| CUDA_VERSION=12.6 | |||
There was a problem hiding this comment.
With these changes, should we update the metadata.json to limit the minimum_required_version to 2.7? Because if someone tries to build and run with images older than 2.7, it will not work anymore.
There was a problem hiding this comment.
Good catch, agreed, @apatole please update H264 metadata.json files accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes updates gxf-mm extensions to the version compatible with GXF 4.1.