-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to GXF 4.1 compatible gxf-mm extensions #546
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arun Patole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested with v2.6.0 release candidate as below, verified this addresses previously observed extension mismatch, no further issues:
./dev_container build_and_run h264_endoscopy_tool_tracking --docker_file applications/h264/Dockerfile --language cpp --base_img <v2.6.0 rc image path>
# App runs and displays as expected
./dev_container launch --img holohub:h264_endoscopy_tool_tracking
./run build h264_endoscopy_tool_tracking --configure-args "-DBUILD_TESTING:BOOL=ON"
cd build/h264_endoscopy_tool_tracking
xvfb-run -a ctest -C Release # cpp and python tests pass
Will wait for v2.6.0 release to merge.
Thanks @tbirdso for the review! |
@@ -38,12 +38,12 @@ gxf_mm_extensions=(["decoderio"]="45081ccb-982e-4946-96f9-0d684f2cfbd0" \ | |||
["encoder"]="ea5c44e4-15db-4448-a3a6-f32004303338") | |||
mkdir -p gxf-mm | |||
mkdir -p ${HOLOSCAN_LIBS_DIR} | |||
CUDA_VERSION=12.2 | |||
CUDA_VERSION=12.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these changes, should we update the metadata.json to limit the minimum_required_version
to 2.7
? Because if someone tries to build and run with images older than 2.7, it will not work anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, agreed, @apatole please update H264 metadata.json
files accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @mocsharp 's note on minimum_required_version
updates
This changes updates gxf-mm extensions to the version compatible with GXF 4.1.