-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distributed version of the h.264 Endoscopy Tool Tracking app #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mocsharp for adding the distributed version of h.264 endoscopy app!
Overall, it looks great to me!
Please consider renaming .cc
files to .hpp
or .cpp
files to be consistent with other projects or within the project (main.cpp
) and left some comments on Holoviz operator's arguments.
Thanks!
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/cloud_inference_fragment.cc
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/main.cpp
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/viz_fragment.cc
Outdated
Show resolved
Hide resolved
12bd6d2
to
fadd548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Added minor comments.
applications/h264/h264_endoscopy_tool_tracking_distributed/README.md
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/CMakeLists.txt
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/cloud_inference_fragment.hpp
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/gxf_imports.hpp
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/README.md
Outdated
Show resolved
Hide resolved
fadd548
to
1c045a9
Compare
…++ & Python Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
1c045a9
to
f6a8252
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mocsharp for adding the distributed version of h264 endoscopy app.
It looks good to me!
This PR adds the distributed version of the h.264 Endoscopy Tool Tracking app in C++ and Python.
The application is composed of three fragments:
video_in
: input a pre-recorded video file using GXF'sVideoReadBitstream
extensioninference
: run the inference using LSTM and the post-processing scriptviz
: display input video and inference resultsNote: this application requires HSDK version 2.5, which includes a fix to hide gRPC symbols.