Add distributed version of the h.264 Endoscopy Tool Tracking app #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigony
previously requested changes
Sep 9, 2024
There was a problem hiding this comment.
Thanks @mocsharp for adding the distributed version of h.264 endoscopy app!
Overall, it looks great to me!
Please consider renaming .cc files to .hpp or .cpp files to be consistent with other projects or within the project (main.cpp) and left some comments on Holoviz operator's arguments.
Thanks!
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/cloud_inference_fragment.cc
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/main.cpp
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/viz_fragment.cc
Outdated
Show resolved
Hide resolved
mocsharp
force-pushed
the
vchang/d-h264
branch
from
12bd6d2
to
fadd548
Compare
tbirdso
reviewed
Sep 10, 2024
applications/h264/h264_endoscopy_tool_tracking_distributed/README.md
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/CMakeLists.txt
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/cloud_inference_fragment.hpp
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/cpp/gxf_imports.hpp
Outdated
Show resolved
Hide resolved
applications/h264/h264_endoscopy_tool_tracking_distributed/README.md
Outdated
Show resolved
Hide resolved
mocsharp
force-pushed
the
vchang/d-h264
branch
from
fadd548
to
1c045a9
Compare
…++ & Python Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
mocsharp
force-pushed
the
vchang/d-h264
branch
from
1c045a9
to
f6a8252
Compare
tbirdso
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the distributed version of the h.264 Endoscopy Tool Tracking app in C++ and Python.
The application is composed of three fragments:
video_in: input a pre-recorded video file using GXF'sVideoReadBitstreamextensioninference: run the inference using LSTM and the post-processing scriptviz: display input video and inference resultsNote: this application requires HSDK version 2.5, which includes a fix to hide gRPC symbols.