Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflows related to translation updates #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add workflows related to translation updates #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc9e61d
Add workflows related to translation updates
nvdaes Sep 12, 2021
47f4a93
Review actions
nvdaes Sep 21, 2021
c0314b9
Review action: add new line at the end of the workflow file
nvdaes Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/check-for-extended-ascii-and-utf-bom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Created by Mesar Hameed (@mhameed)

name: Check that we dont have extended ascii or utf boms in our files

on:
pull_request:

jobs:
extendedAsciiAndBom:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: check for files known to cause problems
run: find . -type f | grep -vP "^./.git" | xargs file | grep -iP "bom|extended|iso"
- name:
if: failure()
uses: unsplash/comment-on-pr@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
msg: "Please note that this pull request seems to contain files other than ascii or utf8 without bom."
30 changes: 30 additions & 0 deletions .github/workflows/checkForTranslations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# https://crontab.guru/crontab.5.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing this file in .github/workflows has an unfortunate side effect that this action would be run for addonTemplate repo which is not what we want. Perhaps these sample actions should be moved to something like GitHubActions/sampleActions and documented in the readme.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling this action for add-on template repository would work but only for this repo. If someone uses this template as is and their add-on is not registered in the translations system they would be getting failures by default. I still maintain that moving these files from .github/workflows and documenting each of these actions in the readme is the simplest way to deal with the problem though I don't have any authority over this repository obviously.


name: Check for l10n updates

on:

workflow_dispatch:

schedule:
# * is a special character in YAML so you have to quote this string
- cron: '1 * * * *' # Once every hour (minute 1)

jobs:
update-translations:
runs-on: windows-latest
steps:
- name: Checkout main
uses: actions/checkout@v2

- name: Push changes
run: |
git config --global user.name github-actions
git config --global user.email [email protected]
git remote add l10n https://github.com/nvdaaddons/${{ github.event.repository.name }}
git fetch l10n
git reset l10n/stable addon/doc addon/locale
git commit -m "Update translations"
git pull
git push