fix 9524 Clean up outdated zh directories under locales

[dpy013]

Link to issue number:

fix #9524

Summary of the issue:

Currently, the zh directory under /locales has not been maintained for a long time.
See 9524 above for details of the problem

Description of user facing changes

Nothing yet.

Description of development approach

First the /locales/zh directory was deleted,
Then it was compiled using the local visual studio2022、
Finally, an installation file was created for testing.

Test Details

Tests were performed using modified builds of the installed and portable versions, respectively,
Tested sapi4 and sapi5 speech synthesizers in Simplified Chinese, typing and browsing the desktop worked fine.
Also checked the /locale directory after compilation and the /locale directory in the installed version, and the zh directory was cleared correctly.

Testing strategy:

Also need to test appveyor compiled builds

Known issues with pull request:

Nothing yet.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files selected but had no reviewable changes (2)

• source/locale/zh/characterDescriptions.dic
• source/locale/zh/symbols.dic

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cary-rowen]

Is #9524 pending implementation?
Can you answer the question raised by this comment?

[CyrilleB79]

At the time of #9524, there were an issue blocking the removal of the zh folder due to symbol pronunciation issue with eSpeak mandarin)? See #9524 (comment) for details.

Is it now fixed on eSpeak's side?

[dpy013]

At the time of #9524, there were an issue blocking the removal of the zh folder due to symbol pronunciation issue with eSpeak mandarin)? See #9524 (comment) for details.

Is it now fixed on eSpeak's side?

hello @CyrilleB79
I just did the following test with nvda_snapshot_pr17105-33739,0238c041.exe.
I first typed the text in Notepad using eSpeak NG.
Then use the left and right arrows to go through the text word by word.
eSpeak NG reports what was typed properly.
Also I tested the text entered in notepad using sapi4 and sapi5.
Then still using the left and right arrows to browse word by word.
sapi4 and sapi5 report what is typed correctly.
The logs will be attached below

[dpy013]

nvda.log