Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speech output for UIA notifications, honoring all NotificationProcessing_* constants #16381

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Improve speech output for UIA notifications, honoring all NotificationProcessing_* constants #16381

wants to merge 3 commits into from
+69 −9

Commits on Aug 22, 2024

  1. ui.message: add optional arguments: 

    * messageID: a unique string identify for this message. This could be used to filter or customize the message, and is used with the following  arguments to configure how multiple messages with the same message ID interupt each other.
speakOnlyMostRecent: If a message with the same message ID has already been queued, the already queued message/s are dropped and only the most recent one is spoken.
* interuptCurrentIfSameID: if speakOnlyMostRecentIfSameID is true, the first existing message in the queue is not dropped, thus a full message is always psoken. E.g. a progress bar quickly going from 0 to 100 in jumps of 1, might say "0, 25, 55, 100" rather than just stuttering until it gets to 100..

UIA NvDAObject's event_UIA_notify: suitable map the UIA notificationProgress argument to appropriate values for speakOnlyMostRecentIfSameID and interuptCurrentIfSameID. Also map them to an appropriate speech priority. E.g.:
* NotificationProcessing_Important*: priority=NOW
* NotificationProcessing_*ThenMostRecent: speakOnlyMostRecentIfSameID=True
* NotificationProcessing_*CurrentThenMostRecent: interuptcurrentIfSameID=False
* NotificationProcessing_*: priority=NEXT
    @michaelDCurran
    michaelDCurran committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    516d752 View commit details
    Browse the repository at this point in the history

  2. Linting

    @michaelDCurran
    michaelDCurran committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1e7d185 View commit details
    Browse the repository at this point in the history

  3. Pre-commit auto-fix

    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0b533ba View commit details
    Browse the repository at this point in the history