-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to create json files from issues #12
Conversation
This probably should still be a draft. I'm actively working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this to learn looking at changes, since I contributed this. Seems that the self.maxDiff is not used and can be removed.
About the license, I thought that add-ons must be licensed undr GPLv2, like NVDA. If this is not the case, this maybe documentet to know what licenses can be used.
There is a section specifically about plugins and drivers I'd prefer not to enforce a license value, it would hide the concern from the author / submitter. They must be actively consider what license they are distributing under and ensure the license is valid / meets requirements etc. |
Thanks for explanations. I"ll follow related PR to create issues in addon-datastore repo.
Enviado desde mi iPhone
… El 20 jul 2022, a las 9:14, Reef Turner ***@***.***> escribió:
There is a section specifically about plugins and drivers
I'm not confident to say whether or not other licenses may be be used.
If we are going to enforce a value, that should happen on the usage side of this workflow, so that there is only one place that needs to be updated if the approach needs to change.
I'd prefer not to enforce a license value, it would hide the concern from the author / submitter. They must be actively consider what license they are distributing under and ensure the license is valid / meets requirements etc.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
Given review actions were minor and have all been addressed, I'm going to merge this, so I can progress nvaccess/addon-datastore#37 |
See #8