Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create json files from issues #12

Merged
merged 10 commits into from
Jul 22, 2022
Merged

Conversation

feerrenrut
Copy link
Contributor

See #8

The planned procedure to submit add-ons to the addon-datastore repo has security issues, as shown in: nvaccess/addon-datastore#35
This intends to provide a way to add and validate add-on metadata by creating issues in addon-datastore, which maybe automerged if checks pass.

_validate/createJson.py Outdated Show resolved Hide resolved
@feerrenrut feerrenrut marked this pull request as draft July 14, 2022 02:24
@feerrenrut
Copy link
Contributor Author

This probably should still be a draft. I'm actively working on this.

@feerrenrut feerrenrut marked this pull request as ready for review July 20, 2022 00:15
Copy link
Sponsor Contributor

@nvdaes nvdaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this to learn looking at changes, since I contributed this. Seems that the self.maxDiff is not used and can be removed.
About the license, I thought that add-ons must be licensed undr GPLv2, like NVDA. If this is not the case, this maybe documentet to know what licenses can be used.

_tests/test_createJson.py Outdated Show resolved Hide resolved
@feerrenrut
Copy link
Contributor Author

There is a section specifically about plugins and drivers
I'm not confident to say whether or not other licenses may be be used.
If we are going to enforce a value, that should happen on the usage side of this workflow, so that there is only one place that needs to be updated if the approach needs to change.

I'd prefer not to enforce a license value, it would hide the concern from the author / submitter. They must be actively consider what license they are distributing under and ensure the license is valid / meets requirements etc.

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented Jul 20, 2022 via email

@seanbudd seanbudd self-requested a review July 21, 2022 02:27
_validate/createJson.py Outdated Show resolved Hide resolved
_validate/createJson.py Outdated Show resolved Hide resolved
_tests/test_createJson.py Outdated Show resolved Hide resolved
@feerrenrut
Copy link
Contributor Author

Given review actions were minor and have all been addressed, I'm going to merge this, so I can progress nvaccess/addon-datastore#37

@feerrenrut feerrenrut merged commit 31d486b into main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants