-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support variable axis #141
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 45.25% 45.91% +0.65%
==========================================
Files 56 56
Lines 3964 4036 +72
Branches 429 450 +21
==========================================
+ Hits 1794 1853 +59
- Misses 2130 2145 +15
+ Partials 40 38 -2 ☔ View full report in Codecov by Sentry. |
Hi @danielroe, the type issues are fixed and I've added tests for Recursive. Sorry I didn't see the failed checks yesterday so it took some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than creating a new property (variableAxis
) I think we ought to try to use font-variation-settings
/variationSettings
which could take a string or an object of dimension/value.
We could then use this to render both the font-face and also detect the required variations from CSS directly rather than require it to be configured.
@danielroe I've also thought about this, but I'm not sure whether |
Now that unifont is released, I think this PR should be closed. For fine-grained variable axis control of providers other than |
we could also open again on unifont - for nuxt/fonts i wanted to think if there was a way to make this zero config but i know it’s taken too long 🙈 |
This PR adds support for variable font axis. It's quite sad that AFAIK only Google provides this level of configuration.