Fix DMA message size calculation #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnissler-rivos
force-pushed
the
github/large_dma_fix
branch
from
a4a0814
to
1d7c355
Compare
|
FWIW, the arch-202307 failure looks unrelated to this change. |
|
arch appears to be fundamentally unstable, see #770 |
|
please add your signed-off-by |
|
LGTM otherwise |
mnissler-rivos
force-pushed
the
github/large_dma_fix
branch
from
1d7c355
to
70dcf91
Compare
|
Thanks for the quick reply!
Gah, my favorite mistake. Fixed now. |
tmakatos
approved these changes
Jan 24, 2024
jlevon
approved these changes
Jan 24, 2024
When performing DMA via VFIO-user commands over the socket, vfu_dma_transfer breaks large requests into chunks according to the client's maximum data transfer size negotiated at connection setup time. This change fixes the calculation of the chunk size for the case where the last chunk is less than the maximum transfer size. Unfortunately, the existing test didn't catch this due to the request size being a multiple of that maximum data transfer size. Adjust the test to make the last chunk size a true remainder. Signed-off-by: Mattias Nissler <[email protected]>
jlevon
force-pushed
the
github/large_dma_fix
branch
from
70dcf91
to
f9ece2c
Compare
|
Thanks for the quick turnaround, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing DMA via VFIO-user commands over the socket, vfu_dma_transfer breaks large requests into chunks according to the client's maximum data transfer size negotiated at connection setup time. This change fixes the calculation of the chunk size for the case where the last chunk is less than the maximum transfer size.
Unfortunately, the existing test didn't catch this due to the request size being a multiple of that maximum data transfer size. Adjust the test to make the last chunk size a true remainder.