Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parser API #10

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update parser API #10

wants to merge 8 commits into from

Conversation

jmleong666
Copy link
Contributor

  • Added image and quote parsing.
  • Reduced redundancy in code by introducing constants.

kevinmingtarja
kevinmingtarja requested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@kevinmingtarja kevinmingtarja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some merge conflicts with Caitlin's PR which I just merged. Can you check it out Jin Ming? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmingtarja kevinmingtarja kevinmingtarja requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmleong666 @kevinmingtarja