Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change name #380

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Option to change name #380

wants to merge 9 commits into from

Conversation

NicholasCF
Copy link
Contributor

Closes #362

Since only MC/Presidential should be able to change it, the permissions to access this is the same as the one for allocating roles.

Normal restrictions such as having to change to a unique username still applies.


Index

Edit screen

spec/controllers/users_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/users_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/users_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/users_controller_spec.rb Outdated Show resolved Hide resolved
app/models/ability.rb Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
@indocomsoft indocomsoft temporarily deployed to dutycommit-pr-380 October 19, 2019 04:55 Inactive
@coveralls
Copy link

coveralls commented Oct 19, 2019

Pull Request Test Coverage Report for Build 2428

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.358%

Totals Coverage Status
Change from base Build 2414: 0.04%
Covered Lines: 582
Relevant Lines: 604

💛 - Coveralls

@indocomsoft indocomsoft temporarily deployed to dutycommit-pr-380 October 19, 2019 05:01 Inactive
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/change_name.scss Outdated Show resolved Hide resolved
@@ -0,0 +1,64 @@
.edit-name {
width: 100%;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names should be able to be changed
5 participants