[Chen-Kuei] iP #577

Chen-Kuei · 2023-09-08T07:11:33Z

Hi! I'm BiuBiu :D

Biu!

BiuBiu frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST SUPER~~ FAST to use

All you need to do is,

download it from HERE.
double-click on it.
add your tasks.
let it manage your tasks for you 🥰

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

text-ui-test/runtest.bat|sh scripts generate a file ACTUAL.TXT. However, .gitignore uses ACTUAL.txt, which means the generated file will not be ignored by Git on non-Windows OS. Let's update .gitignore as ACTUAL.txt -> ACTUAL.TXT

This reverts commit d8a0c18.

This reverts commit 59487b8.

This reverts commit 965afec.

This reverts commit 83e9a44.

# Conflicts: # src/main/java/duke/Deadline.java # src/main/java/duke/Duke.java # src/main/java/duke/Event.java # src/main/java/duke/Parser.java # src/main/java/duke/Storage.java # src/main/java/duke/Task.java # src/main/java/duke/TaskList.java # src/main/java/duke/Todo.java # src/main/java/duke/Ui.java

zacwong2151

LGTM! Here are a few recommendations

add javadocs!
idk, great job on this!

zacwong2151 · 2023-09-09T14:10:12Z

docs/duke.txt

+TODO | read book
+DEADLINE | project | 2022-10-10
+EVENT | meet | 2023-06-12 1400 | 2023-06-12 1600


correct me if I'm wrong, but I believe that this file should be added to your .gitignore file

zacwong2151 · 2023-09-09T14:58:37Z

src/main/java/duke/Ui.java

+                        String taskTime1 = (taskData.length > 2) ? taskData[2] : "";
+                        String taskTime2 = (taskData.length > 3) ? taskData[3] : "";


not very sure what these two task times represent? some commented code would be appreciated

zacwong2151 · 2023-09-09T15:00:19Z

src/main/java/duke/Ui.java

+                    storage.saveTasks(tasks);
+                    break;
+                case "unmark":
+                    int notDoneTaskIndex = Integer.parseInt(parts[1]) - 1;


great job on writing a clear variable name!

zacwong2151 · 2023-09-09T15:04:13Z

src/main/java/duke/Event.java

+    private LocalDateTime startTime;
+    private LocalDateTime endTime;


nice to see that you went beyond what was asked in the iP and made Event have LocalDateTime fields as well. However, this causes some user experience problems, because now in order to enter a Event task you have to write a whole big chunk of text 😬

hcs1203

Well done! Good and clear code with accurate descriptions and good naming mechanisms. Can remove parts of code that make it look like a draft

hcs1203 · 2023-09-10T13:56:28Z

src/main/java/duke/Duke.java

+//            saveTask();
+//        }
+//    }
+//}


Remove commented code. As long as this is a previous version, it will be saved in version control, or store in a separate txt file.

hcs1203 · 2023-09-10T13:56:56Z

src/main/java/duke/Duke.java

+TODO | read book
+DEADLINE | project | 2022-10-10
+EVENT | meeting | 2023-06-12 1400 | 2023-06-12 1800
+ */


State todo on top, delete when done

adammangzijun

Overall a well done and concise piece of code. Good job! 😄

adammangzijun · 2023-09-12T09:11:21Z

src/main/java/duke/Parser.java

+        String[] commandParts = userCommand.split(" ", 2);
+        String taskType = commandParts[0].toLowerCase();
+
+        switch (taskType) {


Cases should be in the same indentation as the switch keyword.

adammangzijun · 2023-09-12T09:15:05Z

src/main/java/duke/Deadline.java

+     * @return The parsed deadline date as a LocalDate object, or null if parsing fails.
+     */
+    private LocalDate parseDeadline(String deadlineString) {
+


I'm not sure if this is an accident but there should be consistency in whether you separate your block statements with 1 line spacing or without.

Removing redundant code in each java class and correcting the indentation for 'case' clauses improve the code quality. Let's remove the indentation of 'case' clauses.

use assert feature

Improve code quality

# Conflicts: # src/main/java/duke/Duke.java

damithc and others added 30 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

Echo

a811c91

Add, List

1df1cc2

Mark As Done

d8a0c18

Revert "Mark As Done"

5a6ac4c

This reverts commit d8a0c18.

Mark As Done

9db4c91

ToDos, Events, Deadlines

f6309a6

Automated Text UI Testing

59487b8

Revert "Automated Text UI Testing"

965afec

This reverts commit 59487b8.

Revert "Revert "Automated Text UI Testing""

b3a3157

This reverts commit 965afec.

Handle Errors

6754850

Merge commit '6754850f9a250ef34efd3d89a8900a789b268630'

c8d0f15

Delete

0f54ab1

Save

1796d07

Merge branch 'branch-Level-7'

7722ebf

Dates and Times

3f0376d

Merge branch 'branch-Level-8'

cefa3b1

OOP(Ui, TaskList, Parser, Storage)

590c044

Merge branch 'master' into add-gradle-support

0947831

Add JUnit tests

3237bca

Merge branch 'add-gradle-support'

25bcabb

Divide classes into packages

ef4a344

Package the App as a JAR file

b71a727

Add JavaDoc comments

9f5214a

Coding standard

83e9a44

Revert "Coding standard"

eaea925

This reverts commit 83e9a44.

Coding Standard

38fdfbf

Find

c1aa9e6

Chen-Kuei added 2 commits September 9, 2023 22:44

Merge all branches

a9e9748

zacwong2151 reviewed Sep 9, 2023

View reviewed changes

hcs1203 reviewed Sep 10, 2023

View reviewed changes

Chen-Kuei added 2 commits September 11, 2023 17:59

Add a GUI to the chatbot

0f748d0

Merge branch 'branch-Level-10'

42b40d3

adammangzijun reviewed Sep 12, 2023

View reviewed changes

Chen-Kuei and others added 23 commits September 13, 2023 12:14

use checkstyle with gradle

b266926

user assert feature

61fb949

Improve code quality

4780351

Removing redundant code in each java class and correcting the indentation for 'case' clauses improve the code quality. Let's remove the indentation of 'case' clauses.

Merge pull request #1 from Chen-Kuei/branch-assertions

46903c2

use assert feature

Merge branch 'master' into branch-CodeQuality

28bf8f4

Merge pull request #2 from Chen-Kuei/branch-CodeQuality

29c8ec8

Improve code quality

improve code quality2.0

56c830f

Merge branch 'branch-assertions' of https://github.com/Chen-Kuei/ip

1e1f26e

improve code quality3.0

50c2d23

Merge branch 'master' of https://github.com/Chen-Kuei/ip

e05baa0

# Conflicts: # src/main/java/duke/Duke.java

update GUI design and improve code quality

a3d776d

update GUI

130c3aa

C-Update

7492a70

Merge branch 'branch-C-Update'

81d1619

add a user guide

a847eb9

update user guide

1a4ed7c

add title bar of the window, update Ui.png

4c09fcd

update user guide, update main window

82ec07f

improve code quality(modify too-long methods)

d47e6b9

Merge branch 'branch-A-CodeQuality'

a555e2d

Correct the 'loadTasks' method, remove redundant code

0913d02

create a jar file

1a1623a

Compile with Java 11 JDK

af798d0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Chen-Kuei] iP #577

[Chen-Kuei] iP #577

Chen-Kuei commented Sep 8, 2023 •

edited

Loading

zacwong2151 left a comment

zacwong2151 Sep 9, 2023

zacwong2151 Sep 9, 2023

zacwong2151 Sep 9, 2023

zacwong2151 Sep 9, 2023

hcs1203 left a comment

hcs1203 Sep 10, 2023

hcs1203 Sep 10, 2023

adammangzijun left a comment

adammangzijun Sep 12, 2023

adammangzijun Sep 12, 2023

		String taskTime1 = (taskData.length > 2) ? taskData[2] : "";
		String taskTime2 = (taskData.length > 3) ? taskData[3] : "";

		private LocalDateTime startTime;
		private LocalDateTime endTime;

[Chen-Kuei] iP #577

Are you sure you want to change the base?

[Chen-Kuei] iP #577

Conversation

Chen-Kuei commented Sep 8, 2023 • edited Loading

Hi! I'm BiuBiu :D

BiuBiu frees your mind of having to remember things you need to do. It's,

All you need to do is,

And it is FREE!

Features:

zacwong2151 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hcs1203 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adammangzijun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chen-Kuei commented Sep 8, 2023 •

edited

Loading