-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ryan Chew] Duke Increments #355
Open
iltep64
wants to merge
50
commits into
nus-cs2103-AY1920S1:master
Choose a base branch
from
iltep64:pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,334
−16
Open
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
65f72a8
Add support for Gradle workflow
j-lum 0112efe
Add sample checkstyle configuration
j-lum 7faa65a
Added Greet, Echo, Exit features
iltep64 46c55c6
Implement list add and show features.
iltep64 94b4414
Created Task class to represent tasks.
iltep64 4cec14a
Implemented marking a task as done.
iltep64 013cc37
Refactor IO interface into DukeIO instance, and Duke logic into objec…
iltep64 9303e1d
Implement deadline task class and addition logic
iltep64 5abe5d0
Refactor out and improve task-adding logic.
iltep64 11f4134
Create a uniform command interface, with parsing logic.
iltep64 3ec4d4e
Implement dialog block logic, so messages get aggregated into a singl…
iltep64 b79c5c0
Add header to list command output.
iltep64 3a0d632
Add Event task and make it available by the 'event' command.
iltep64 0139127
Add basic error handling support.
iltep64 16718fb
Added deletion functionality.
iltep64 8dd4b9b
Implement basic JSON decoder
iltep64 d7e9187
Add basic JSON writer
iltep64 501ae91
Add type registry for JSON serializiation
iltep64 9880921
Add convenience functions for JSON encoding/decoding.
iltep64 db72071
Refactor task types to enums
iltep64 6ca4441
Add JSON builder class for Tasks
iltep64 1cf63ce
Add listOf function, and produce ArrayList<> values instead of just L…
iltep64 f5ccf6e
Use JSON to load/store task list
iltep64 a0d17c1
Fix completed status not being loaded
iltep64 0b162a2
Add date parsing logic
iltep64 c842c6f
Have EventTask and DeadlineTask to use date logic.
iltep64 355f065
Merge branch 'branch-Level-7'
iltep64 93b6e1c
Merge branch 'branch-Level-8'
iltep64 dce444a
Add encoder lookup cache for Registry, and avoid printing debug messages
iltep64 45172d8
Move all classes into (sub)packages of org.duke
iltep64 9f28efa
Add task find command
iltep64 ed5ea49
Reformat code to satisfy standards
iltep64 8c16531
Add javadocs to public classes and methods.
iltep64 c907b2c
Merge branch 'branch-Level-9'
iltep64 c5eee9a
Merge branch 'codingstandard'
iltep64 af1b0d4
Merge branch 'javadocs'
iltep64 7e2227e
Merge branch 'gradle'
iltep64 e0b6066
Add JAR build plugin.
iltep64 63d9c81
Add tests for Command and DateParser, and automate via Gradle.
iltep64 3bfe760
Refactor out IO and command parsing.
iltep64 1e6e594
Implement a basic JavaFX UI.
iltep64 31fb5b4
Merge branch 'branch-Level-10'
iltep64 b04abda
Encapsulate Command fields.
iltep64 354adca
Beautify DukeFx UI, by adding colored message boxes for Duke and user.
iltep64 f653e2d
Extract command handlers into their own classes, and add a help command.
iltep64 7ea74be
Refactor storage out into own class, and improve CounterDecorator.
iltep64 00772ef
Refactored JavaFX UI to use FXML custom components.
iltep64 6d9eb22
Fix JavaFX startup classpath issues.
iltep64 1eebc7b
Add user guide/documentation.
iltep64 b508421
Set theme jekyll-theme-slate
iltep64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import java.util.Map; | ||
import java.util.HashMap; | ||
import java.util.regex.Pattern; | ||
public class Command { | ||
public final String type; | ||
public final String arguments; | ||
public final Map<String,String> namedArguments; | ||
|
||
public Command(String type, String arguments, Map<String, String> namedArguments) { | ||
this.type = type; | ||
this.arguments = arguments; | ||
this.namedArguments = namedArguments; | ||
} | ||
|
||
private static final Pattern switchBoundary = Pattern.compile("\\s+/"); | ||
private static final Pattern cmdBoundary = Pattern.compile("\\s+"); | ||
|
||
public static Command parse(String input) { | ||
input = input.trim(); | ||
|
||
//Split on the presence of any switches | ||
String[] splits = switchBoundary.split(input); | ||
|
||
//First split value is "cmd-type args..." | ||
String[] mainArgs = cmdBoundary.split(splits[0], 2); | ||
if(mainArgs[0].isEmpty()) { | ||
return null; | ||
} | ||
|
||
String type = mainArgs[0]; | ||
//If no arguments, leave as empty string | ||
String arguments = mainArgs.length > 1 ? mainArgs[1] : ""; | ||
Map<String, String> namedArguments = new HashMap<>(); | ||
|
||
if(splits.length > 1) { | ||
//Each split value is "switch-name args..." | ||
//with no preceding slash | ||
for(int i=1;i<splits.length;i++) { | ||
if(splits[i].isEmpty()) { | ||
continue; | ||
} | ||
//Split at first whitespace | ||
String[] switchArgs = cmdBoundary.split(splits[i], 2); | ||
String switchName = switchArgs[0]; | ||
//If no arguments, leave as empty string | ||
String switchArguments = switchArgs.length > 1 ? switchArgs[1] : ""; | ||
namedArguments.put(switchName, switchArguments); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I find it a bit confusing to use |
||
} | ||
} | ||
return new Command(type, arguments, namedArguments); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be more readable to include spaces to become
for (int i = 1; i < splits.length; i++)