-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lawnce Goh] Duke Increments #347
Open
lawncegoh
wants to merge
75
commits into
nus-cs2103-AY1920S1:master
Choose a base branch
from
lawncegoh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toolVersion block in to Gradle code sample to prevent errors.
# Conflicts: # src/main/java/Duke.class # src/main/java/Duke.java
# Conflicts: # src/main/java/Duke.class # src/main/java/Duke.java
Numbering wrong
Hi Bot,
I actually merged the 2 branches into my main branch through pull requests.
But it still says that they were not accepted in my fork.
… On 6 Sep 2019, at 9:07 PM, NUS SE PR Bot ***@***.***> wrote:
Hi @lawncegoh <https://github.com/lawncegoh>, your pull request title is invalid.
For PR sent as submission of iP (Individual Project), the PR name should be in the format of [{Your name}] Duke Increments (such as [John Doe] Duke Increments).
Please follow the above format strictly and edit your title for reprocessing.
Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot <https://github.com/nus-cs2103/nus-se-pr-bot/issues> and add a link to this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#347?email_source=notifications&email_token=ALQONVZKGMHCHZ4NW23GYOTQIJIX3A5CNFSM4IS3W4Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CZDZQ#issuecomment-528847334>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALQONV654JAQDAO6OKKBGPDQIJIX3ANCNFSM4IS3W4QQ>.
|
# Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Release of Duke