flatten var at top of functions. #104
Conversation
rachitnigam
force-pushed
the
flatdecl
branch
from
68c751e
to
2cbf1b4
Compare
rachitnigam
force-pushed
the
flatdecl
branch
from
2cbf1b4
to
1edb87e
Compare
|
I've fixed the issues. Let me know if I'm good to merge (Do I need benchmarking data before a merge?) |
|
yea, run benchmarks |
|
Seems to be slightly faster. There seem to some failures |
|
Did the failures go away with a rerun? |
|
No, there is a bug in Sudoku.scala |
|
This code looks totally fine, so you should figure out whatever the bug is and fix it. |
|
This needs to be benchmarked before merging. |
| @@ -11,3 +11,4 @@ demo-webpage/html/runner.js | |||
| package-lock.json | |||
| auth-trial/html/src-noconflict | |||
| /benchmarks | |||
| .vscode | |||
There was a problem hiding this comment.
wow, why? you need to stick to vim for a little longer.
There was a problem hiding this comment.
Ah well, I wanted to feel like I wasn't in the 90s (plus I finally got a computer that can support an actual editor) . Didn't really work out. VS Code's vim emulation isn't that great.
There was a problem hiding this comment.
Well, being fluent in Vim or Emacs is an important part of street cred. But you probably have that already.
There was a problem hiding this comment.
Yeah, I am fluent in vim. I even wrote most of the vim stuff for pyret: brownplt/pyret-lang#1150
(the name of the PR is in sync with the Pyret theme :) )
No description provided.