Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change title to fix folder name for Windows user #1839

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

michaeldorner
Copy link
Contributor

This PR fixes the issue for Windows users introduced in #1780 by a title that contains : (thanks @eallion for the hint!)

@eallion
Copy link
Contributor

eallion commented Nov 9, 2024

😊

@unacro
Copy link
Contributor

unacro commented Nov 10, 2024

And it's the right way for fix #1835.

Good job. Hope to merge it ASAP.

@deining
Copy link
Contributor

deining commented Nov 10, 2024

And it's the right way for fix #1835.

I agree.

However, this PR does not fully resolve #1835. Even with this PR in place, you get an error when using this theme as go/hugo module:

go get github.com/michaeldorner/blowfish/v2@8f6778d80d0055e9d2070d1e7085d035dd8c453d
go: downloading github.com/michaeldorner/blowfish/v2 v2.0.0-20241109090851-8f6778d80d00
go: github.com/michaeldorner/blowfish/v2@8f6778d80d0055e9d2070d1e7085d035dd8c453d: create zip: exampleSite/content/users/Xeonzilla’s Note/feature.jpg: malformed file path "exampleSite/content/users/Xeonzilla’s Note/feature.jpg": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.it.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.it.md": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.ja.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.ja.md": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.md": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.zh-cn.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.zh-cn.md": invalid char '’'

This is due to the use of in a directory name.

@michaeldorner
Copy link
Contributor Author

michaeldorner commented Nov 11, 2024

Darn, sorry for the sloppy work. I fixed it.

Since we partially use already domains as folder names, may I suggest to consistently roll out this naming convention to avoid this problem in the future?

@unacro
Copy link
Contributor

unacro commented Nov 14, 2024

Darn, sorry for the sloppy work. I fixed it.

Since we partially use already domains as folder names, may I suggest to consistently roll out this naming convention to avoid this problem in the future?

Can't agree more. Similar situations is as hell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants