Enhance Unit Conversion, rename _gal to _galUS, and add _galUK #1856

edwardtianye · 2021-06-17T07:44:46Z

The default gallon is of US standard.
So I added UK standard as _galUK, and renamed _gal to _galUS.
And revised the toolbox tips accordingly.

Change-Id: I4a7f2e024ca82a3996ad3e395c8f62ca4170ec9e

Change-Id: I64a6500b66db4455217920a1e73efd5848216411

Renamed zoom button Change-Id: I476c0991d5ab88c6642b793fbe10debbcca4e014

Change-Id: If3983c16d3bfa0de31aefe8a3f5c650e1858f822

Change-Id: Iaff562cca9af3eb903d6cc8a529c730184235e4b

Change-Id: I06d1850074b266a694d74e4db4c754ff156c8098

Change-Id: I7548d11fb114b2605ce34d3bda0776277b79ff9d

Change-Id: Icd65c4e19b78cd8751d6b1b583c112abb08c9237

Change-Id: If8904ca4e7d306376de785a125fe5fba168de718

Change-Id: I841bd22077cccacc7d2a4a541cca2e463f13925b

Change-Id: I834444aee7dd547c71254df4658c0db05eb101d7

Change-Id: If88f91d6e925dbb2ad293b537661eb3d137ea826

A previous fix to prevent AlphaLock from interfering with the long press feature broke the long press selection. Revert the changes and find another solution to the previous problem. We compare the alpha status to both the state of the Alpha key and the Lock, which makes sense : Lock is supposed to mimic Alpha being continuously pressed. Change-Id: I1349eb83f8971d3a5efcb10de020bb6c0aed64a1

Do not take strong variations into account if they would erase more interesting variations. Change-Id: I6299a64bed449a611f90eda4234af10a183958d1

Change-Id: Ia46966270418a339f8a37e8a1971a7f7dd046034

Change-Id: Ia28a7ffb826a9b6e3618b222b6ed9d0d43de308a

Added an event to represent the typing of text that is not on the device's keyboard. ExternalText event's text is read from a buffer, that will be filled when the event is generated. ExternalText only exists on the simulator. Change-Id: Ie78d2c7c2de91da986a1ce2130a5ecd123db48ee

Change-Id: I9683a8ba819b1a4aad18bcc4759160509e424d4e

Generate an ExternalText event when catching a SDL_TextInputEvent whose text cannot be boiled down to one of the regular events. Change-Id: I036fa2a153c8351979521d7f8cba6b62aa64604b

Change-Id: Id7f68f4dfb4727453a02437a0b824492a8c94730

The size of the ExternalText events shared buffer is now defined as the size of the SDL_TextInputEvent 'text' field, as it should. Also fix a wrong parameter being passed to a strlcpy. Change-Id: I6a57d49d61fec8a009c4711efce564c65544e571

Change-Id: Iaef80fdbb6083be688fadc2b5fc515dbbd0d004c

Change-Id: I67c21d59263b7eddd7ee8ee9e61c168e6b013d13

Change-Id: I0d0d7dca0e167cfcb40f4b26d8208e12056ebf40

Change-Id: Ie2e028a5030e1b0d3f133efdde971645d5b4687b

Change-Id: Iaae5ee4292e33f923f47590ee4520bac44c5d750

Added some missing resets of the Auto and Normalize statuses Change-Id: I5514a2566c1f6ba73d04b526402b428b2edce4b4

Only notify the delegate to the refresh the button when the status has changed. Change-Id: I6689d2c292ff96039a68cd1b437b18df5fb98829

fraccionaria -> fracionária

CLAassistant · 2021-06-17T07:44:52Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 11 committers have signed the CLA.

✅ GabrielNumworks
✅ HugoNumworks
✅ EmilieNumworks
✅ LeaNumworks
✅ thePeras
✅ M4xi1m3
✅ edwardtianye
✅ RedGl0w
❌ MartijnNumworks
❌ RobertaNumWorks
❌ Edward Tian

Edward Tian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2021-06-17T07:48:56Z

	.text	.rodata	.bss	.data
Base	686 164 bytes	274 039 bytes	180 720 bytes	1 368 bytes
Head	686 140 bytes	274 327 bytes	180 720 bytes	1 376 bytes
	- 24 bytes	+ 288 bytes	+ 0 bytes	+ 8 bytes
	- 0.0 %	+ 0.1 %	+ 0.0 %	+ 0.6 %

artaxxx · 2021-06-18T07:58:06Z

Thanks for your PR @edwardtianye ! Let me suggest some changes:

_gal should remain _gal and the legend "Gallon"
let's add _galUK with the legend "British gallon"
results or additional results should be given in _gal (not in _galUK), except if it's an explicit conversion: 1_L ⇾ _galUK for instance

edwardtianye · 2021-06-18T11:15:24Z

Thanks for your prompt response, per to you suggestion, have the changes done.

github-actions · 2021-06-18T11:19:02Z

	.text	.rodata	.bss	.data
Base	686 164 bytes	274 039 bytes	180 720 bytes	1 368 bytes
Head	686 140 bytes	274 215 bytes	180 720 bytes	1 376 bytes
	- 24 bytes	+ 176 bytes	+ 0 bytes	+ 8 bytes
	- 0.0 %	+ 0.1 %	+ 0.0 %	+ 0.6 %

edwardtianye · 2021-06-18T11:32:05Z

Sorry, should make a PR on version-15 branch?

GabrielNumworks

Thanks for the PR !
I tested it and found that _galUK appears in results instead of _gal. To fix that, you'd need to change the number of authorized volume representative in simplification. This is done in poincare/src/unit.cpp, in the definition of VolumeRepresentative::standardRepresentative : the fourth argument of the call to DefaultFindBestRepresentative needs to be changed from numberOfRepresentatives() - 1 to numberOfRepresentatives() - 2.
Appart from that and the small style comments, this is good for me !

GabrielNumworks · 2021-07-01T07:46:25Z

apps/toolbox.en.i18n

@@ -91,6 +91,7 @@ UnitVolumeCup = "Cup"
 UnitVolumePint = "Pint"
 UnitVolumeQuart = "Quart"
 UnitVolumeGallon = "Gallon"
+UnitVolumeGallonUk = "Gallon(UK)"


Could you change this to "British gallon" instead ? Same in the other languages.

GabrielNumworks · 2021-07-01T07:46:40Z

poincare/include/poincare/unit.h

@@ -414,7 +414,7 @@ class UnitNode final : public ExpressionNode {
  public:
    constexpr static VolumeRepresentative Default() { return VolumeRepresentative(nullptr, 0., Prefixable::None, Prefixable::None); }
    const Vector<int> dimensionVector() const override { return Vector<int>{.time = 0, .distance = 3, .mass = 0, .current = 0, .temperature = 0, .amountOfSubstance = 0, .luminuousIntensity = 0}; }
-    int numberOfRepresentatives() const override { return 8; }
+    int numberOfRepresentatives() const override { return 9; } // Edward modified from 8 to 9 for obtaining galUK


You can remove this comment.

GabrielNumworks and others added 30 commits November 4, 2020 15:58

[poincare/zoom] Accelerate normal range search

f491be2

Change-Id: I4a7f2e024ca82a3996ad3e395c8f62ca4170ec9e

[shared] Rename ZoomParameterController

0e4de43

Change-Id: I64a6500b66db4455217920a1e73efd5848216411

[interactive_curve_view_controller] Zoom button

3a87e47

Renamed zoom button Change-Id: I476c0991d5ab88c6642b793fbe10debbcca4e014

[poincare/zoom] Use std::min & max

29f4712

Change-Id: If3983c16d3bfa0de31aefe8a3f5c650e1858f822

[sequence] Format comment

194cd04

Change-Id: Iaff562cca9af3eb903d6cc8a529c730184235e4b

[poincare/zoom] Change struct to class

a76e546

Change-Id: I06d1850074b266a694d74e4db4c754ff156c8098

[apps/shared] Add toggle buttons in Graph view

2f97dab

Change-Id: I7548d11fb114b2605ce34d3bda0776277b79ff9d

[i18n] Update Graph view parameters wording

3f25a37

Change-Id: Icd65c4e19b78cd8751d6b1b583c112abb08c9237

[poincare/zoom] Simplify plot ranges after adding margins

bb8a28a

Change-Id: If8904ca4e7d306376de785a125fe5fba168de718

[apps/shared] Update translation size -> frequency

14e2f62

Change-Id: I841bd22077cccacc7d2a4a541cca2e463f13925b

[NL] correct spelling mistake

52adea0

[NL] adjust translation in python app

6628e76

[apps/statistics] Fix horizontal alignement for size legend

8161695

Change-Id: I834444aee7dd547c71254df4658c0db05eb101d7

[apps/statiastics] Rename i18n messages accurately

2740056

Change-Id: If88f91d6e925dbb2ad293b537661eb3d137ea826

[poincare/zoom] Limit explosion detection

82c4fe2

Do not take strong variations into account if they would erase more interesting variations. Change-Id: I6299a64bed449a611f90eda4234af10a183958d1

[poincare] Handle equal negative numbers in GCD LCM

93b5a3f

Change-Id: Ia46966270418a339f8a37e8a1971a7f7dd046034

[poincare/zoom] Add test for x*ln(x)

65156c8

Change-Id: Ia28a7ffb826a9b6e3618b222b6ed9d0d43de308a

[ion/utf8_helper] Method to check text compliance

8181753

Change-Id: I9683a8ba819b1a4aad18bcc4759160509e424d4e

[ion/simulator/events_keyboard] Serve ExternalText

4ea8263

Generate an ExternalText event when catching a SDL_TextInputEvent whose text cannot be boiled down to one of the regular events. Change-Id: I036fa2a153c8351979521d7f8cba6b62aa64604b

[ion/events] Factor includes of layout_events.h

b0b6fe3

Change-Id: Id7f68f4dfb4727453a02437a0b824492a8c94730

[ion/events] Fix ExternalText buffer size

aadf8f5

The size of the ExternalText events shared buffer is now defined as the size of the SDL_TextInputEvent 'text' field, as it should. Also fix a wrong parameter being passed to a strlcpy. Change-Id: I6a57d49d61fec8a009c4711efce564c65544e571

[apps/shared] Set buttonAction method as protected

cab22fc

Change-Id: Iaef80fdbb6083be688fadc2b5fc515dbbd0d004c

[apps/statistics] Add temporary parameters for histogram

a922e44

Change-Id: I67c21d59263b7eddd7ee8ee9e61c168e6b013d13

[apps/statistics] Add pop-up to confirm parameter discard

b2d7ee8

Change-Id: I0d0d7dca0e167cfcb40f4b26d8208e12056ebf40

[apps/regression] Add escape case if data is not suitable for regression

f58633b

Change-Id: Ie2e028a5030e1b0d3f133efdde971645d5b4687b

[apps/regression] Comment assert that cannot be satisfied

f2ba5da

Change-Id: Iaae5ee4292e33f923f47590ee4520bac44c5d750

[interactive_curve_view_range] Missing resets

82a77df

Added some missing resets of the Auto and Normalize statuses Change-Id: I5514a2566c1f6ba73d04b526402b428b2edce4b4

[interactive_curve_view_range] Status unchanged

5a5955b

Only notify the delegate to the refresh the button when the status has changed. Change-Id: I6689d2c292ff96039a68cd1b437b18df5fb98829

EmilieNumworks and others added 15 commits January 6, 2021 16:31

build: Version 15.3.0

49b74fb

[simulator/android] Bump targetSdkVersion

ed2d5e3

build: Version 15.3.1

11ef4bd

[makefiles] Fix epsilon_run on windows

37f78c5

[Inliner] Fixed memory leak

4718ff8

[Inliner] Use png_destroy_read_struct

d7f7bbe

[pyUSB] Update to V1.1.1 a54ebc7

cf8ecfb

[build] Add comment to dfu.py

6b8db10

[Variable box] Do not replace symbol in sequence name

9960cd5

[mathsVarBox] Changed symbolLayout for sequences

b2221a7

A Little change to the portuguese language

60bf04b

fraccionaria -> fracionária

[apps] Fixed missing dynamically-generated dependency

15e5089

[poincare/addition] Fix issue with symbolic computation

b782f4a

[poincare] Add symbolicComputation setter

09dd52c

Enhance Unit Conversion, rename _gal to _galUS, and add _galUK

f162649

Rename _galUS to _gal according to artaxxx's suggestion.

04f86ed

artaxxx requested a review from GabrielNumworks June 30, 2021 14:45

GabrielNumworks requested changes Jul 1, 2021

View reviewed changes

EmilieNumworks force-pushed the master branch from 8cfa1d7 to 7bab48b Compare August 20, 2021 12:30

EmilieNumworks force-pushed the master branch 2 times, most recently from e385767 to 974bf08 Compare December 1, 2021 16:37

EmilieNumworks force-pushed the master branch from 7c15e2e to e82884b Compare August 23, 2022 14:47

EmilieNumworks force-pushed the master branch from bb3baa7 to e4c3a98 Compare February 2, 2023 11:08

HugoNumworks force-pushed the master branch from 117eea7 to 35a8a17 Compare July 11, 2024 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Unit Conversion, rename _gal to _galUS, and add _galUK #1856

Enhance Unit Conversion, rename _gal to _galUS, and add _galUK #1856

edwardtianye commented Jun 17, 2021

CLAassistant commented Jun 17, 2021 •

edited

Loading

github-actions bot commented Jun 17, 2021

artaxxx commented Jun 18, 2021

edwardtianye commented Jun 18, 2021

github-actions bot commented Jun 18, 2021

edwardtianye commented Jun 18, 2021

GabrielNumworks left a comment

GabrielNumworks Jul 1, 2021

GabrielNumworks Jul 1, 2021

Enhance Unit Conversion, rename _gal to _galUS, and add _galUK #1856

Are you sure you want to change the base?

Enhance Unit Conversion, rename _gal to _galUS, and add _galUK #1856

Conversation

edwardtianye commented Jun 17, 2021

CLAassistant commented Jun 17, 2021 • edited Loading

github-actions bot commented Jun 17, 2021

artaxxx commented Jun 18, 2021

edwardtianye commented Jun 18, 2021

github-actions bot commented Jun 18, 2021

edwardtianye commented Jun 18, 2021

GabrielNumworks left a comment

Choose a reason for hiding this comment

GabrielNumworks Jul 1, 2021

Choose a reason for hiding this comment

GabrielNumworks Jul 1, 2021

Choose a reason for hiding this comment

CLAassistant commented Jun 17, 2021 •

edited

Loading