[Rasterizer] Fix math i on windows #1717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After lauching the console, if we fetch a script we mark it as fetched. When the variable box displays variables from imported scripts, it scans all the variables from the scripts marked as fetched.
In the variable box
After scrolling down
Because we can now, it might need to be de-factorized later, if more classes inherit from alternate_empty_nested_menu_controller
Eg : arr|ow(x,y,dx,dy) should give arrow(|,,,)
If the commandLength is > than the buffer size, we have to escape at some point to avoid overflowing the buffer.
Change-Id: I610726ed5966d353397be923b76dd003297940a7
Change-Id: I6ebec412b4b6612710476274a8665375d21f9ef8
Without this change, we would get weird "reduced" expression, such as multiplication(undef, _s), but we do not always check sSimplificationHasBeenInterrupted afterwards.
If an expression hasUnits and is then reduced, it might not have units anymore for instance if it was replaced with undefined). Scenario: Enter "[5000000000000000]^20 _s" in the calculation app
Change-Id: I99a523e9e88ea9c3064e4367d96b01edb0020df9
Change-Id: I7a5e12f6f3d79da802149a6aeef88387941ccdd8
KDColor::blend used to produce different colors when blending two identical colors (ex : use draw_string in Python to print white text on a white background). blend now escapes early when its two color arguments are identical. Change-Id: I01dc5a0d5e4e6a20e09fee0f346dafc313dae97b
When computing the barycenter between two colors, the some of the two factors a and (1-a) was equal to 255/256 instead of 1. Change-Id: Ia9a779d43470ef42d9430ad730e842da0f007140
Change-Id: If1792bd9ec44052238632d28b806f5582b190fe9
Change-Id: I5fb68608657d2f604c8cb7c9294382ed4a8603ff
Additional checks for interruptions were making the kandinsky module slower. /!\ Some scripts are now very difficult to interrupt Change-Id: I4c18273d8895deaac68084411a52556c8459d52b
Keyboard interruption used to be checked once every 20000 calls to micropython_port_vm_hook_loop. However, if costly functions were executed in between calls to this method, the delay for activating interruptions would increase. Now, keyboard interruption is checked after a fixed amount of time has passed. This way, if the process waits a long time between two calls to micropython_port_vm_hook_loop, it is still interrupted in a timely manner. Change-Id: I37ca3bd4a996fa086078f504340dd857526e356a
A check for interruption in ConsoleController::printText caused script to immediately stop when launched after an interrupted script. This check was used to break out of infinite print loop, but now becomes redundant with how micropython_port_vm_hook_loop was changed. Change-Id: Ifa8d415e1b2c2406ad67300eb14ce46889af296f
EmilieNumworks
force-pushed
the
master
branch
2 times, most recently
from
e385767
to
974bf08
Compare
EmilieNumworks
force-pushed
the
master
branch
from
bb3baa7
to
e4c3a98
Compare
|
Looks like this branch needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1351
It works perfectly on windows 7 and Linux (with wine)