Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHL: bump (musl) linux image [wheel build] #27088

Merged
merged 5 commits into from
Aug 26, 2024
Merged

WHL: bump (musl) linux image [wheel build] #27088

merged 5 commits into from
Aug 26, 2024

Conversation

andyfaff
Copy link
Member

closes #27066.

  • bumps the musllinux image from 1_1 to 1_2.
  • bumps the ubuntu images used for wheel building from 20.04 to 22.04.

@andyfaff
Copy link
Member Author

@mattip

@mattip
Copy link
Member

mattip commented Aug 1, 2024

Should we have any overlap and release both wheels for 2.1 or can we not release a 1_2 wheel with no prior announcement?

@andyfaff
Copy link
Member Author

andyfaff commented Aug 1, 2024

It would have to be added as a matrix. I'm not sure of the compatibility of 1_2. https://discuss.python.org/t/wheels-for-musl-alpine/7084/22?page=2 might be useful.

@mattip
Copy link
Member

mattip commented Aug 4, 2024

1_1 wheels should run on 1_2, I don't think pip will install 1_2 wheels on 1_1. Although 1_1 is 2.5 % of the current downloads vs. 97.5% for 1_2, 2.5% is still a lot of NumPy users. Are we OK not releasing NumPy2.1 for that small group?

@andyfaff
Copy link
Member Author

andyfaff commented Aug 4, 2024

Ok. How about we use 1_1 for the next release, but 1_2 following that, and make an announcement on the ML?

@rgommers
Copy link
Member

rgommers commented Aug 5, 2024

How about we use 1_1 for the next release, but 1_2 following that, and make an announcement on the ML?

That sounds like a good plan to me. Second-best plan is to just drop 1_1 now. Building for both doesn't sound right, too much effort/builds for little gain.

@mattip
Copy link
Member

mattip commented Aug 11, 2024

Should probably change this line as well, so we are testing on 1_2

image: quay.io/pypa/musllinux_1_1_x86_64
. Are there other places we use musllinux?

@andyfaff
Copy link
Member Author

Send intention email to ML on 2024_08_11

@mattip
Copy link
Member

mattip commented Aug 11, 2024

Cross-linking to the mailing list discussion.

@andyfaff
Copy link
Member Author

I had a look at the repo and couldn't find any more places to make a change from 1_1 to 1_2. Is there an appropriate place in the documentation to mention this?

@mattip
Copy link
Member

mattip commented Aug 12, 2024

Maybe add a release note?

@charris
Copy link
Member

charris commented Aug 23, 2024

@andyfaff A release note would be good, then we can put this in.

@charris charris added this to the 2.2.0 release milestone Aug 23, 2024
@andyfaff
Copy link
Member Author

Can you remind me where I make those?

@charris
Copy link
Member

charris commented Aug 23, 2024

where I make those?

doc/release/upcoming_changes. There are already some release notes there that you can use to see how to do it.

@andyfaff
Copy link
Member Author

@charris, I've made that release note.

@mattip mattip merged commit f0e381a into numpy:main Aug 26, 2024
66 checks passed
@mattip
Copy link
Member

mattip commented Aug 26, 2024

Thanks @andyfaff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUILD: musslinux_1_1 is EOL, we should use musllinux_1_2
4 participants