-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WHL: bump (musl) linux image [wheel build] #27088
Conversation
Should we have any overlap and release both wheels for 2.1 or can we not release a 1_2 wheel with no prior announcement? |
It would have to be added as a matrix. I'm not sure of the compatibility of 1_2. https://discuss.python.org/t/wheels-for-musl-alpine/7084/22?page=2 might be useful. |
1_1 wheels should run on 1_2, I don't think pip will install 1_2 wheels on 1_1. Although 1_1 is 2.5 % of the current downloads vs. 97.5% for 1_2, 2.5% is still a lot of NumPy users. Are we OK not releasing NumPy2.1 for that small group? |
Ok. How about we use 1_1 for the next release, but 1_2 following that, and make an announcement on the ML? |
That sounds like a good plan to me. Second-best plan is to just drop |
Should probably change this line as well, so we are testing on 1_2 numpy/.github/workflows/linux_musl.yml Line 27 in 9312d5e
|
Send intention email to ML on 2024_08_11 |
Cross-linking to the mailing list discussion. |
I had a look at the repo and couldn't find any more places to make a change from 1_1 to 1_2. Is there an appropriate place in the documentation to mention this? |
Maybe add a release note? |
@andyfaff A release note would be good, then we can put this in. |
Can you remind me where I make those? |
|
@charris, I've made that release note. |
Co-authored-by: Matti Picus <[email protected]>
Thanks @andyfaff |
closes #27066.