Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
Poetry n'étant officiellement pas géré par le buildpack python de Heroku et donc par Scalingo, le buildpack semble générer le
requirements.txt
et installer le projet directement sans garderpoetry
lui-même, ce qui fait que les commandes préfixées parpoetry run
ne marchent pas, et semble par ailleurs régulièrement poser des problèmes au déploiement.Il serait probablement possible de changer les commandes ou de les préfixer de manière optionnelle, mais autant passer sur
pipenv
qui est la méthode recommandée par Scalingo.🔍 Implémentation
poetry
parpipenv
(création duPipfile
/Pipfile.lock
, suppression des sections pertinentes dupyproject.toml
et du fichierpoetry.lock
)Makefile
make
ont été revues ou ajoutées, voir leMakefile
.