Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics #179

Merged
merged 21 commits into from
Jun 17, 2024
Merged

Metrics #179

merged 21 commits into from
Jun 17, 2024

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Jun 17, 2024 •
edited
Loading

Change notes:

  1. Removed numalogic pipeline. The codebase for pipeline now uses numalogic codebase. Please refer here: https://github.com/numaproj/numalogic
  2. This repo is repurposed as prometheus metrics library for numalogic repository.

@s0nicboOm
add: numalogic prometheus based metrics
217a805 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
add: update toml file
cf8bf42 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
add: update toml file
96fae1c 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
add: utility file for the config
4115cf7 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
add: metric config
b195e24 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
rename file
6929c00 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
feat: add docstrings
4f9ee26 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
feat: add testcases
4cc5d88 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
feat: add testcases
d44c5dd 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
update python version
81de2c7 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
clean the repo
e02f957 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
fix: have BaseMetric not protected
7cd87ca 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
fix: import
48e2b0a 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
fix: add workflows
411fd65 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
fix: coverage workflow
8db6474 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
test pypi workflow
83ee6d5 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
revert the worklfow for version tag release only
c206e6b 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
fix lint
c523be6 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
fix lint
c20d188 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm
update project version
473e162 
Signed-off-by: Kushal Batra <[email protected]>
ab93
ab93 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a huge breaking change can you add a description of the changes? Basically make the PR notes

@s0nicboOm
fix: update maintainers
e6dcbde 
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm s0nicboOm merged commit a778dd2 into main Jun 17, 2024
3 of 4 checks passed
@s0nicboOm s0nicboOm deleted the metrics branch June 17, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab93 ab93 ab93 approved these changes

@nkoppisetty nkoppisetty Awaiting requested review from nkoppisetty

@vigith vigith Awaiting requested review from vigith vigith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s0nicboOm @ab93