Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use numalogic v0.4a0 for using redis model store #133

Merged
merged 12 commits into from
May 23, 2023
Merged

Conversation

ab93
Copy link
Member

@ab93 ab93 commented May 11, 2023

No description provided.

ab93 added 10 commits May 8, 2023 17:38
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #133 (390885f) into main (7cada11) will decrease coverage by 1.06%.
The diff coverage is 69.11%.

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   83.55%   82.50%   -1.06%     
==========================================
  Files          20       20              
  Lines        1107     1126      +19     
  Branches      121      116       -5     
==========================================
+ Hits          925      929       +4     
- Misses        157      175      +18     
+ Partials       25       22       -3     
Impacted Files Coverage Δ
numaprom/udsink/train.py 53.27% <45.45%> (-4.63%) ⬇️
numaprom/udf/threshold.py 91.22% <58.33%> (-8.78%) ⬇️
numaprom/udf/inference.py 92.53% <66.66%> (-2.85%) ⬇️
numaprom/udf/preprocess.py 88.63% <68.75%> (-11.37%) ⬇️
numaprom/clients/sentinel.py 80.00% <70.00%> (-8.89%) ⬇️
numaprom/udsink/train_rollout.py 85.24% <84.61%> (+1.03%) ⬆️
numaprom/tools.py 92.74% <100.00%> (+6.93%) ⬆️
numaprom/udf/postprocess.py 95.50% <100.00%> (-0.05%) ⬇️
numaprom/udf/window.py 94.91% <100.00%> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ab93 ab93 changed the title Numalogic v0.4a0 feat!: use numalogic v0.4a0 for using redis model store May 11, 2023
@ab93 ab93 marked this pull request as ready for review May 11, 2023 23:45
@ab93 ab93 self-assigned this May 11, 2023
@ab93 ab93 added the enhancement New feature or request label May 11, 2023
@ab93 ab93 requested review from sarabala1979 and whynowy May 11, 2023 23:46
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, few minor comments

numaprom/udf/inference.py Show resolved Hide resolved
numaprom/udf/window.py Outdated Show resolved Hide resolved
numaprom/udf/window.py Outdated Show resolved Hide resolved
numaprom/udsink/train.py Outdated Show resolved Hide resolved
numaprom/udsink/train.py Show resolved Hide resolved
numaprom/udsink/train.py Show resolved Hide resolved
@ab93 ab93 requested a review from nkoppisetty May 22, 2023 22:30
@ab93 ab93 merged commit 77675bb into main May 23, 2023
@ab93 ab93 deleted the numalogic-v0.4a0 branch May 23, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants