fix: avoid unwanted watcher creation and reduce being stuck with udf is restarted #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
vigith
approved these changes
Aug 29, 2023
Signed-off-by: Yashash H L <[email protected]>
vigith
changed the title
vigith
reviewed
Aug 29, 2023
|
|
||
| // invoke the reduceFn method with datumCh channel | ||
| wg.Add(1) | ||
| go func() { |
pkg/udf/rpc/grpc_reduce.go
Outdated
|
|
||
| // pass key and window information inside the context | ||
| mdMap := map[string]string{ | ||
| shared.WinStartTime: strconv.FormatInt(partitionID.Start.UnixMilli(), 10), | ||
| shared.WinEndTime: strconv.FormatInt(partitionID.End.UnixMilli(), 10), | ||
| } | ||
|
|
||
| ctx = metadata.NewOutgoingContext(ctx, metadata.New(mdMap)) | ||
| cctx, cancel := context.WithCancel(ctx) |
There was a problem hiding this comment.
to exit from readloop go routine when we return from ApplyReduce.
There was a problem hiding this comment.
It should be okay to just do ctx, cancel := context.WithCancel(ctx), do not need to give a new cctx.
This is a common patten to make sure everyone in this function watches this ctx will properly exit if the function returns, no matter if it's expectedly or unexpectedly.
whynowy
reviewed
Aug 29, 2023
| case msg, ok := <-messageStream: | ||
| if msg != nil { | ||
| // create datum from isbMessage and send it to datumCh channel for reduceFn | ||
| go func() { |
There was a problem hiding this comment.
go func() {
defer close(datumCh)
for {
select {
if xxx {
return
}
xxxx
}
}
}()Signed-off-by: Yashash H L <[email protected]> Co-authored-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
vigith
reviewed
Aug 30, 2023
pkg/udf/rpc/grpc_reduce.go
Outdated
Comment on lines
118
to
125
| // if the messageStream is closed, break the loop | ||
| if !ok { | ||
| return | ||
| } | ||
| // if the message is nil, break the loop | ||
| if msg == nil { | ||
| return | ||
| } |
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
whynowy
approved these changes
Aug 30, 2023
pkg/udf/rpc/grpc_reduce.go
Outdated
|
|
||
| // pass key and window information inside the context | ||
| mdMap := map[string]string{ | ||
| shared.WinStartTime: strconv.FormatInt(partitionID.Start.UnixMilli(), 10), | ||
| shared.WinEndTime: strconv.FormatInt(partitionID.End.UnixMilli(), 10), | ||
| } | ||
|
|
||
| ctx = metadata.NewOutgoingContext(ctx, metadata.New(mdMap)) | ||
| cctx, cancel := context.WithCancel(ctx) |
There was a problem hiding this comment.
It should be okay to just do ctx, cancel := context.WithCancel(ctx), do not need to give a new cctx.
This is a common patten to make sure everyone in this function watches this ctx will properly exit if the function returns, no matter if it's expectedly or unexpectedly.
Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1001