feat: Add side input sdkclient and grpc #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
reviewed
Aug 16, 2023
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
|
tests are still failing |
Signed-off-by: Sidhant Kohli <[email protected]>
yhl25
reviewed
Aug 23, 2023
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
whynowy
reviewed
Aug 24, 2023
|
|
||
| // UDSgRPCBasedUDSideinput applies user defined side input over gRPC (over Unix Domain Socket) client/server | ||
| // where server is the UDSideInput. | ||
| type UDSgRPCBasedUDSideinput struct { |
There was a problem hiding this comment.
Do we need to add this proxy struct? The reason we have it in other places like udf is, they need to implement the MapApplier interface, it's not need to for side inputs.
There was a problem hiding this comment.
Using the client directly now
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
jy4096
approved these changes
Aug 25, 2023
|
|
||
| // Check if the current value is same as the new value | ||
| // If true then don't update file again and return | ||
| if err == nil && bytes.Equal(currentValue, value) { |
There was a problem hiding this comment.
in the future when file size gets larger we may consider using hash...
vigith
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.