Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated fields #813

Merged
merged 1 commit into from
Jun 29, 2023
Merged

chore: remove deprecated fields #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions api/json-schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17508,19 +17508,10 @@
"description": "From vertex type.",
"type": "string"
},
"limits": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.DeprecatedEdgeLimits",
"description": "Deprecated, use vertex.spec.limits instead.\n\nLimits define the limitations such as buffer read batch size for the edge, will override pipeline level settings."
},
"onFull": {
"description": "OnFull specifies the behaviour for the write actions when the inter step buffer is full. There are currently two options, retryUntilSuccess and discardLatest. if not provided, the default value is set to \"retryUntilSuccess\"",
"type": "string"
},
"parallelism": {
"description": "Deprecated, use vertex.spec.partitions instead.\n\nParallelism is only effective when the \"to\" vertex is a reduce vertex, if it's not provided, the default value is set to \"1\". Parallelism is ignored when the \"to\" vertex is not a reduce vertex.",
"format": "int32",
"type": "integer"
},
"to": {
"type": "string"
},
Expand Down Expand Up @@ -17700,21 +17691,6 @@
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.DeprecatedEdgeLimits": {
"properties": {
"bufferMaxLength": {
"description": "BufferMaxLength is used to define the max length of a buffer. It overrides the settings from pipeline limits.",
"format": "int64",
"type": "integer"
},
"bufferUsageLimit": {
"description": "BufferUsageLimit is used to define the percentage of the buffer usage limit, a valid value should be less than 100, for example, 85. It overrides the settings from pipeline limits.",
"format": "int64",
"type": "integer"
}
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.Edge": {
"properties": {
"conditions": {
Expand All @@ -17724,19 +17700,10 @@
"from": {
"type": "string"
},
"limits": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.DeprecatedEdgeLimits",
"description": "Deprecated, use vertex.spec.limits instead.\n\nLimits define the limitations such as buffer read batch size for the edge, will override pipeline level settings."
},
"onFull": {
"description": "OnFull specifies the behaviour for the write actions when the inter step buffer is full. There are currently two options, retryUntilSuccess and discardLatest. if not provided, the default value is set to \"retryUntilSuccess\"",
"type": "string"
},
"parallelism": {
"description": "Deprecated, use vertex.spec.partitions instead.\n\nParallelism is only effective when the \"to\" vertex is a reduce vertex, if it's not provided, the default value is set to \"1\". Parallelism is ignored when the \"to\" vertex is not a reduce vertex.",
"format": "int32",
"type": "integer"
},
"to": {
"type": "string"
}
Expand Down Expand Up @@ -19079,11 +19046,6 @@
"format": "int64",
"type": "integer"
},
"targetBufferUsage": {
"description": "TargetBufferUsage is used to define the target percentage of the buffer availability. A valid and meaningful value should be less than the BufferUsageLimit defined in the Edge spec (or Pipeline spec), for example, 50. It only applies to UDF and Sink vertices because only they have buffers to read. Deprecated: use targetBufferAvailability instead. Will be removed in v0.9",
"format": "int64",
"type": "integer"
},
"targetProcessingSeconds": {
"description": "TargetProcessingSeconds is used to tune the aggressiveness of autoscaling for source vertices, it measures how fast you want the vertex to process all the pending messages. Typically increasing the value, which leads to lower processing rate, thus less replicas. It's only effective for source vertices.",
"format": "int64",
Expand Down
38 changes: 0 additions & 38 deletions api/openapi-spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17519,19 +17519,10 @@
"description": "From vertex type.",
"type": "string"
},
"limits": {
"description": "Deprecated, use vertex.spec.limits instead.\n\nLimits define the limitations such as buffer read batch size for the edge, will override pipeline level settings.",
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.DeprecatedEdgeLimits"
},
"onFull": {
"description": "OnFull specifies the behaviour for the write actions when the inter step buffer is full. There are currently two options, retryUntilSuccess and discardLatest. if not provided, the default value is set to \"retryUntilSuccess\"",
"type": "string"
},
"parallelism": {
"description": "Deprecated, use vertex.spec.partitions instead.\n\nParallelism is only effective when the \"to\" vertex is a reduce vertex, if it's not provided, the default value is set to \"1\". Parallelism is ignored when the \"to\" vertex is not a reduce vertex.",
"type": "integer",
"format": "int32"
},
"to": {
"type": "string"
},
Expand Down Expand Up @@ -17704,21 +17695,6 @@
}
}
},
"io.numaproj.numaflow.v1alpha1.DeprecatedEdgeLimits": {
"type": "object",
"properties": {
"bufferMaxLength": {
"description": "BufferMaxLength is used to define the max length of a buffer. It overrides the settings from pipeline limits.",
"type": "integer",
"format": "int64"
},
"bufferUsageLimit": {
"description": "BufferUsageLimit is used to define the percentage of the buffer usage limit, a valid value should be less than 100, for example, 85. It overrides the settings from pipeline limits.",
"type": "integer",
"format": "int64"
}
}
},
"io.numaproj.numaflow.v1alpha1.Edge": {
"type": "object",
"required": [
Expand All @@ -17733,19 +17709,10 @@
"from": {
"type": "string"
},
"limits": {
"description": "Deprecated, use vertex.spec.limits instead.\n\nLimits define the limitations such as buffer read batch size for the edge, will override pipeline level settings.",
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.DeprecatedEdgeLimits"
},
"onFull": {
"description": "OnFull specifies the behaviour for the write actions when the inter step buffer is full. There are currently two options, retryUntilSuccess and discardLatest. if not provided, the default value is set to \"retryUntilSuccess\"",
"type": "string"
},
"parallelism": {
"description": "Deprecated, use vertex.spec.partitions instead.\n\nParallelism is only effective when the \"to\" vertex is a reduce vertex, if it's not provided, the default value is set to \"1\". Parallelism is ignored when the \"to\" vertex is not a reduce vertex.",
"type": "integer",
"format": "int32"
},
"to": {
"type": "string"
}
Expand Down Expand Up @@ -19066,11 +19033,6 @@
"type": "integer",
"format": "int64"
},
"targetBufferUsage": {
"description": "TargetBufferUsage is used to define the target percentage of the buffer availability. A valid and meaningful value should be less than the BufferUsageLimit defined in the Edge spec (or Pipeline spec), for example, 50. It only applies to UDF and Sink vertices because only they have buffers to read. Deprecated: use targetBufferAvailability instead. Will be removed in v0.9",
"type": "integer",
"format": "int64"
},
"targetProcessingSeconds": {
"description": "TargetProcessingSeconds is used to tune the aggressiveness of autoscaling for source vertices, it measures how fast you want the vertex to process all the pending messages. Typically increasing the value, which leads to lower processing rate, thus less replicas. It's only effective for source vertices.",
"type": "integer",
Expand Down
15 changes: 0 additions & 15 deletions config/base/crds/full/numaflow.numaproj.io_pipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,23 +79,11 @@ spec:
type: object
from:
type: string
limits:
properties:
bufferMaxLength:
format: int64
type: integer
bufferUsageLimit:
format: int32
type: integer
type: object
onFull:
enum:
- retryUntilSuccess
- discardLatest
type: string
parallelism:
format: int32
type: integer
to:
type: string
required:
Expand Down Expand Up @@ -3012,9 +3000,6 @@ spec:
targetBufferAvailability:
format: int32
type: integer
targetBufferUsage:
format: int32
type: integer
targetProcessingSeconds:
format: int32
type: integer
Expand Down
27 changes: 0 additions & 27 deletions config/base/crds/full/numaflow.numaproj.io_vertices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,23 +633,11 @@ spec:
type: integer
fromVertexType:
type: string
limits:
properties:
bufferMaxLength:
format: int64
type: integer
bufferUsageLimit:
format: int32
type: integer
type: object
onFull:
enum:
- retryUntilSuccess
- discardLatest
type: string
parallelism:
format: int32
type: integer
to:
type: string
toVertexLimits:
Expand Down Expand Up @@ -1509,9 +1497,6 @@ spec:
targetBufferAvailability:
format: int32
type: integer
targetBufferUsage:
format: int32
type: integer
targetProcessingSeconds:
format: int32
type: integer
Expand Down Expand Up @@ -3160,23 +3145,11 @@ spec:
type: integer
fromVertexType:
type: string
limits:
properties:
bufferMaxLength:
format: int64
type: integer
bufferUsageLimit:
format: int32
type: integer
type: object
onFull:
enum:
- retryUntilSuccess
- discardLatest
type: string
parallelism:
format: int32
type: integer
to:
type: string
toVertexLimits:
Expand Down
42 changes: 0 additions & 42 deletions config/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2524,23 +2524,11 @@ spec:
type: object
from:
type: string
limits:
properties:
bufferMaxLength:
format: int64
type: integer
bufferUsageLimit:
format: int32
type: integer
type: object
onFull:
enum:
- retryUntilSuccess
- discardLatest
type: string
parallelism:
format: int32
type: integer
to:
type: string
required:
Expand Down Expand Up @@ -5457,9 +5445,6 @@ spec:
targetBufferAvailability:
format: int32
type: integer
targetBufferUsage:
format: int32
type: integer
targetProcessingSeconds:
format: int32
type: integer
Expand Down Expand Up @@ -8758,23 +8743,11 @@ spec:
type: integer
fromVertexType:
type: string
limits:
properties:
bufferMaxLength:
format: int64
type: integer
bufferUsageLimit:
format: int32
type: integer
type: object
onFull:
enum:
- retryUntilSuccess
- discardLatest
type: string
parallelism:
format: int32
type: integer
to:
type: string
toVertexLimits:
Expand Down Expand Up @@ -9634,9 +9607,6 @@ spec:
targetBufferAvailability:
format: int32
type: integer
targetBufferUsage:
format: int32
type: integer
targetProcessingSeconds:
format: int32
type: integer
Expand Down Expand Up @@ -11285,23 +11255,11 @@ spec:
type: integer
fromVertexType:
type: string
limits:
properties:
bufferMaxLength:
format: int64
type: integer
bufferUsageLimit:
format: int32
type: integer
type: object
onFull:
enum:
- retryUntilSuccess
- discardLatest
type: string
parallelism:
format: int32
type: integer
to:
type: string
toVertexLimits:
Expand Down
Loading
Loading