Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Using limit instead of request to calculate usage percentage, fixes #1784 #1947

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

fix(UI): Using limit instead of request to calculate usage percentage, fixes #1784 #1947

wants to merge 24 commits into from

Conversation

SaniyaKalamkar
Copy link

Fixes #1784. used cpu/memory limit instead of cpu/memory request to calculate usage percentages.

Saniya Kalamkar and others added 24 commits August 12, 2024 16:48
Using limit instead of request to calculate usage percentage
99ff81a
@samhith-kakarla
chore: add readBytesTotal metric (numaproj#1879)
26b7635 
Signed-off-by: Samhith Kakarla <[email protected]>
@whynowy
chore: refactor and output messages to the status when unhealthy (num…
de99a79 
…aproj#1895)

Signed-off-by: Derek Wang <[email protected]>
@vigith @whynowy @yhl25
feat: Rust k8s model for Numaflow (numaproj#1898)
bf4a269 
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Co-authored-by: Derek Wang <[email protected]>
Co-authored-by: Yashash H L <[email protected]>
@vigith
chore: add cargo fmt to numaflow-models (numaproj#1902)
b65edc1 
Signed-off-by: Vigith Maurice <[email protected]>
@yhl25 @vigith
chore: publishing extension image (numaproj#1874)
4747e56 
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
@whynowy
feat: introducing MonoVertex (numaproj#1911)
1dbc091 
Signed-off-by: Derek Wang <[email protected]>
@vigith
chore: update the proto files (numaproj#1910)
0290704 
Signed-off-by: Vigith Maurice <[email protected]>
@whynowy
chore: rust codegen templates (numaproj#1913)
032dffd 
Signed-off-by: Derek Wang <[email protected]>
@github-actions
docs: updated CHANGELOG.md (numaproj#1916)
0df21eb 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vigith @yhl25 @kohlisid
feat: source to sink with an optional transformer without ISB (numapr…
7971f22 
…oj#1904)

Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Co-authored-by: Yashash H L <[email protected]>
Co-authored-by: Sidhant Kohli <[email protected]>
@vigith
chore: mono-vertex code review (numaproj#1917)
e120495 
Signed-off-by: Vigith Maurice <[email protected]>
@kohlisid @vigith
feat: add server-info support and versioning to MonoVertex (numaproj#…
8581493 
…1918)

Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
@yhl25 @vigith
chore: improve shutdown and health checks for MonoVertex (numaproj#1919)
1b00923 
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
@vigith
chore: rename proto name for sourcetransform (numaproj#1921)
175f952 
Signed-off-by: Vigith Maurice <[email protected]>
@yhl25 @vigith
chore: reorganize rust code (numaproj#1922)
adcad2a 
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
@mdwarne1
Add Lockheed to Users.md (numaproj#1934)
2f15b7d 
Signed-off-by: Matt Warner <[email protected]>
@vigith
chore: add transformer to MonoVertex example (numaproj#1935)
4d2cc2c 
Signed-off-by: Vigith Maurice <[email protected]>
@yhl25 @vigith
fix: retry failed messages for MonoVertex sink (numaproj#1933)
bbfe02a 
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
@KeranYang @yhl25
chore: implement APIs for mono vertex UI server (numaproj#1931)
e9c5fa2 
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Co-authored-by: Yashash H L <[email protected]>
@yhl25
chore: update last updated time for mvtx (numaproj#1939)
7f44c43 
Signed-off-by: Yashash H L <[email protected]>
@yhl25 @vigith
chore: avoid partial acks (numaproj#1938)
b05ad78 
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
feat: Using limit to calculate usage percentage. Fixes numaproj#1784
96784f9 
Signed-off-by: Saniya Kalamkar <[email protected]>
@SaniyaKalamkar
feat: Using limit to calculate usage percentage. Fixes numaproj#1784
036ee66 
Signed-off-by: Saniya Kalamkar <[email protected]>
@whynowy
Copy link
Member

whynowy commented Aug 14, 2024

@SaniyaKalamkar - Fix the DCO please. https://github.com/numaproj/numaflow/pull/1947/checks?check_run_id=28785600760

@whynowy whynowy changed the title Using limit instead of request to calculate usage percentage, fixes #1784 fix(UI): Using limit instead of request to calculate usage percentage, fixes #1784 Aug 14, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.18%. Comparing base (11ca09f) to head (036ee66).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
+ Coverage   57.93%   58.18%   +0.24%     
==========================================
  Files         402      402              
  Lines       28001    28061      +60     
==========================================
+ Hits        16223    16326     +103     
+ Misses      10847    10799      -48     
- Partials      931      936       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith
Copy link
Member

vigith commented Aug 15, 2024

perhaps rebase?

@KeranYang
Copy link
Member

Hey @SaniyaKalamkar, Yashash and I just made changes to our e2e tests and committed to the main. If you continue working on your branch, you might see some un-expected e2e testing failures. To fix them, please rebase. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy Awaiting requested review from whynowy whynowy will be requested when the pull request is marked ready for review whynowy is a code owner

@vigith vigith Awaiting requested review from vigith vigith will be requested when the pull request is marked ready for review vigith is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Use cpu/mem limit instead of request to calculate the usage percentage
8 participants
@SaniyaKalamkar @whynowy @vigith @KeranYang @samhith-kakarla @yhl25 @kohlisid @mdwarne1