Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changing health status thresholds #1905

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

samhith-kakarla
Copy link
Contributor

Explain what this PR does.

Signed-off-by: Samhith Kakarla <[email protected]>
@samhith-kakarla
Copy link
Contributor Author

Pipline is reaching warning/critical state when we stop scaling:
pipeline_with_config_1
Screenshot 2024-08-06 at 2 37 11 PM

Signed-off-by: Samhith Kakarla <[email protected]>
Signed-off-by: Samhith Kakarla <[email protected]>
Signed-off-by: Samhith Kakarla <[email protected]>
@samhith-kakarla
Copy link
Contributor Author

unit tests were erroring because of change in thresholds so i changed the cutoff values in the tests to be dependent on DefaultBufferUsageLimit and match the new thresholds. Also added TestHealthThresholds to show that thresholds are actually changing as expected when BufferUsageLimit changes

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.24%. Comparing base (9cf7624) to head (3b8a8a8).
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/daemon/server/service/health_status.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1905      +/-   ##
==========================================
- Coverage   59.82%   58.24%   -1.59%     
==========================================
  Files         286      291       +5     
  Lines       23689    24390     +701     
==========================================
+ Hits        14172    14205      +33     
- Misses       8588     9243     +655     
- Partials      929      942      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samhith-kakarla samhith-kakarla marked this pull request as ready for review August 7, 2024 23:21
// criticalBufferThreshold is the threshold above which the health of a vertex is critical
criticalBufferThreshold = 95
criticalBufferThreshold = v1alpha1.DefaultBufferUsageLimit * float64(90) // 95
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The threshold for different vertex should be different - based on the vertex limits configuration, is this right? @kohlisid

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes now that we have it relative, it can vary vertex to vertex.
The code will need changes to compare each timeline using the limits for the corresponding vertex limits.

@KeranYang
Copy link
Member

Hey @samhith-kakarla , Yashash and I just made changes to our e2e tests and committed to the main. If you continue working on your branch, you might see some un-expected e2e testing failures. To fix them, please rebase. Thanks!

@vigith vigith marked this pull request as draft August 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants