Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust buckets for histogram metrics #1145

Merged
merged 1 commit into from
Oct 3, 2023
Merged

chore: adjust buckets for histogram metrics #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/forward/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,23 +119,23 @@ var forwardAChunkProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO
Subsystem: "forwarder",
Name: "forward_chunk_processing_time",
Help: "Processing times of the entire forward a chunk (100 microseconds to 20 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})

// udfProcessingTime is a histogram to Observe UDF Processing times as a whole
var udfProcessingTime = promauto.NewHistogramVec(prometheus.HistogramOpts{
Subsystem: "forwarder",
Name: "udf_processing_time",
Help: "Processing times of UDF (100 microseconds to 15 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})

// concurrentUDFProcessingTime is a histogram to Observe UDF Processing times as a whole
var concurrentUDFProcessingTime = promauto.NewHistogramVec(prometheus.HistogramOpts{
Subsystem: "forwarder",
Name: "concurrent_udf_processing_time",
Help: "Processing times of Concurrent UDF (100 microseconds to 20 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})

// udfReadMessagesCount is used to indicate the number of messages read by UDF
Expand Down
2 changes: 1 addition & 1 deletion pkg/sinks/forward/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,5 @@ var forwardAChunkProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO
Subsystem: "sink_forwarder",
Name: "forward_chunk_processing_time",
Help: "Processing times of the entire forward a chunk (100 microseconds to 20 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})
6 changes: 3 additions & 3 deletions pkg/sources/forward/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,23 +112,23 @@ var forwardAChunkProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO
Subsystem: "source_forwarder",
Name: "forward_chunk_processing_time",
Help: "Processing times of the entire forward a chunk (100 microseconds to 20 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})

// transformerProcessingTime is a histogram to Observe Source Transformer Processing times as a whole
var transformerProcessingTime = promauto.NewHistogramVec(prometheus.HistogramOpts{
Subsystem: "source_forwarder",
Name: "transformer_processing_time",
Help: "Processing times of source transformer (100 microseconds to 15 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})

// concurrentTransformerProcessingTime is a histogram to Observe Source Transformer Processing times as a whole
var concurrentTransformerProcessingTime = promauto.NewHistogramVec(prometheus.HistogramOpts{
Subsystem: "source_forwarder",
Name: "concurrent_transformer_processing_time",
Help: "Processing times of Concurrent source transformer (100 microseconds to 20 minutes)",
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60),
Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10),
}, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName})

// transformerReadMessagesCount is used to indicate the number of messages read by source transformer
Expand Down
Loading