Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extracting redis streams source #1113

Merged
merged 13 commits into from
Oct 1, 2023
Merged

extracting redis streams source #1113

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb47e2c
extracting redis streams source
juliev0 Sep 28, 2023
1bde032
remove redis streams from e2e
juliev0 Sep 28, 2023
afefbc6
fix: empty commit
juliev0 Sep 28, 2023
a4a4635
remove documentation
juliev0 Sep 28, 2023
ef127c3
remove documentation
juliev0 Sep 28, 2023
30c7666
remove reference to doc
juliev0 Sep 29, 2023
d08a972
fix: empty commit
juliev0 Sep 29, 2023
94a0c2d
remove redis-streams from Makefile
juliev0 Sep 29, 2023
9a689b2
remove the redis stream source struct
juliev0 Sep 29, 2023
df18db0
remove redis streams source type
juliev0 Sep 29, 2023
c672f65
fixing controller-gen version
juliev0 Sep 29, 2023
8f3625c
remove lingering references to redis streams
juliev0 Sep 29, 2023
a868bee
updated index values in source
juliev0 Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
max-parallel: 10
matrix:
driver: [jetstream]
case: [e2e, diamond-e2e, transformer-e2e, kafka-e2e, http-e2e, nats-e2e, redis-streams-e2e, sdks-e2e, reduce-e2e, udsource-e2e]
case: [e2e, diamond-e2e, transformer-e2e, kafka-e2e, http-e2e, nats-e2e, sdks-e2e, reduce-e2e, udsource-e2e]
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ test-e2e-suite-2:
test-kafka-e2e:
test-http-e2e:
test-nats-e2e:
test-redis-streams-e2e:
test-sdks-e2e:
test-reduce-e2e:
test-%:
Expand Down
50 changes: 0 additions & 50 deletions api/json-schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18972,53 +18972,6 @@
},
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.RedisStreamsSource": {
"properties": {
"consumerGroup": {
"type": "string"
},
"masterName": {
"description": "Only required when Sentinel is used",
"type": "string"
},
"password": {
"$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector",
"description": "Redis password secret selector"
},
"readFromBeginning": {
"description": "if true, stream starts being read from the beginning; otherwise, the latest",
"type": "boolean"
},
"sentinelPassword": {
"$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector",
"description": "Sentinel password secret selector"
},
"sentinelUrl": {
"description": "Sentinel URL, will be ignored if Redis URL is provided",
"type": "string"
},
"stream": {
"type": "string"
},
"tls": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.TLS"
},
"url": {
"description": "Redis URL",
"type": "string"
},
"user": {
"description": "Redis user",
"type": "string"
}
},
"required": [
"stream",
"consumerGroup",
"readFromBeginning"
],
"type": "object"
},
"io.numaproj.numaflow.v1alpha1.SASL": {
"properties": {
"gssapi": {
Expand Down Expand Up @@ -19282,9 +19235,6 @@
"nats": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.NatsSource"
},
"redisStreams": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.RedisStreamsSource"
},
"transformer": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.UDTransformer"
},
Expand Down
50 changes: 0 additions & 50 deletions api/openapi-spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18958,53 +18958,6 @@
}
}
},
"io.numaproj.numaflow.v1alpha1.RedisStreamsSource": {
"type": "object",
"required": [
"stream",
"consumerGroup",
"readFromBeginning"
],
"properties": {
"consumerGroup": {
"type": "string"
},
"masterName": {
"description": "Only required when Sentinel is used",
"type": "string"
},
"password": {
"description": "Redis password secret selector",
"$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector"
},
"readFromBeginning": {
"description": "if true, stream starts being read from the beginning; otherwise, the latest",
"type": "boolean"
},
"sentinelPassword": {
"description": "Sentinel password secret selector",
"$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector"
},
"sentinelUrl": {
"description": "Sentinel URL, will be ignored if Redis URL is provided",
"type": "string"
},
"stream": {
"type": "string"
},
"tls": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.TLS"
},
"url": {
"description": "Redis URL",
"type": "string"
},
"user": {
"description": "Redis user",
"type": "string"
}
}
},
"io.numaproj.numaflow.v1alpha1.SASL": {
"type": "object",
"required": [
Expand Down Expand Up @@ -19269,9 +19222,6 @@
"nats": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.NatsSource"
},
"redisStreams": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.RedisStreamsSource"
},
"transformer": {
"$ref": "#/definitions/io.numaproj.numaflow.v1alpha1.UDTransformer"
},
Expand Down
81 changes: 0 additions & 81 deletions config/base/crds/full/numaflow.numaproj.io_pipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7206,87 +7206,6 @@ spec:
- subject
- url
type: object
redisStreams:
properties:
consumerGroup:
type: string
masterName:
type: string
password:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
readFromBeginning:
type: boolean
sentinelPassword:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
sentinelUrl:
type: string
stream:
type: string
tls:
properties:
caCertSecret:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
clientCertSecret:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
clientKeySecret:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
insecureSkipVerify:
type: boolean
type: object
url:
type: string
user:
type: string
required:
- consumerGroup
- readFromBeginning
- stream
type: object
transformer:
properties:
builtin:
Expand Down
81 changes: 0 additions & 81 deletions config/base/crds/full/numaflow.numaproj.io_vertices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3049,87 +3049,6 @@ spec:
- subject
- url
type: object
redisStreams:
properties:
consumerGroup:
type: string
masterName:
type: string
password:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
readFromBeginning:
type: boolean
sentinelPassword:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
sentinelUrl:
type: string
stream:
type: string
tls:
properties:
caCertSecret:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
clientCertSecret:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
clientKeySecret:
properties:
key:
type: string
name:
type: string
optional:
type: boolean
required:
- key
type: object
insecureSkipVerify:
type: boolean
type: object
url:
type: string
user:
type: string
required:
- consumerGroup
- readFromBeginning
- stream
type: object
transformer:
properties:
builtin:
Expand Down
Loading
Loading