Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Numaflow API v1.1 initial commit #1038

Merged
merged 14 commits into from
Sep 12, 2023
Merged

Conversation

jy4096
Copy link
Contributor

@jy4096 jy4096 commented Sep 12, 2023

  • Add v1_1 handler pkg (a copy and paste from v1)
    • add ListClusterSummary
    • TODO: missing handlers
  • Add v1_1 router
  • Add v1_1 common response data type
    • TODO: detailed response data type for each API call

TODO: replace v1 with v1_1

Please refer to internal API design doc for more info.

jyu6 added 6 commits September 11, 2023 16:31
@jy4096 jy4096 changed the base branch from main to ui-api-v1_1 September 12, 2023 16:01
@jy4096 jy4096 changed the base branch from ui-api-v1_1 to ui-1.0 September 12, 2023 16:20
@jy4096 jy4096 marked this pull request as ready for review September 12, 2023 19:58
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need v1_1 since we are working on the same branch and/also UI server and UI are in the same image?

Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure we will remove v1_1 when we merge to the main branch.

@jy4096 jy4096 merged commit b680df8 into numaproj:ui-1.0 Sep 12, 2023
2 checks passed
@jy4096 jy4096 deleted the api-v1_1-init-0 branch September 12, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants