Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: put square vertices in start guide diagrams #1009

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

jasonzeshengchen
Copy link
Contributor

Replaced the even-odd diagram with a new one containing square vertices, to be more consistent with the UI.

@jasonzeshengchen jasonzeshengchen marked this pull request as ready for review August 30, 2023 19:07
@@ -94,7 +94,7 @@ kubectl delete -f https://raw.githubusercontent.com/numaproj/numaflow/stable/exa

Now we will walk you through creating an advanced pipeline. In our example, this is called the `even-odd` pipeline, illustrated by the following diagram:

![Pipeline Diagram](assets/even-odd.png)
![Pipeline Diagram](assets/even-odd-square.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name does not match, PNG vs. png.

If we use the new image, remove the old one from assets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good now. thanks!

fixed png capitalization. Deleted old even-odd pipeline diagram.

Signed-off-by: Jason Zesheng Chen <[email protected]>
@whynowy whynowy merged commit 9d06332 into numaproj:main Aug 30, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants