chore: unify the event time of messages to drop #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the event time of messages to drop to 1969-12-31 00:00:00 +0000 UTC across all our SDKs. Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 94.84% 94.85%
=======================================
Files 29 29
Lines 1086 1088 +2
Branches 71 71
=======================================
+ Hits 1030 1032 +2
Misses 32 32
Partials 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ab93
reviewed
Oct 13, 2023
Comment on lines
15
to
20
| """ | ||
| event_time_to_drop 1969-12-31 00:00:00 +0000 UTC is set to be slightly | ||
| earlier than Unix epoch -1 (1969-12-31 23:59:59.999 +0000 UTC) | ||
| As -1 is used on Numaflow to indicate watermark is not available, event_time_to_drop is | ||
| used to indicate that the message is dropped hence, excluded from watermark calculation | ||
| """ |
There was a problem hiding this comment.
Let's add this after the class docstring, in the same space
| used to indicate that the message is dropped hence, excluded from watermark calculation | ||
| """ | ||
|
|
||
| event_time_to_drop = datetime(1969, 12, 31, 0, 0, 0, tzinfo=timezone.utc) |
There was a problem hiding this comment.
Do we really need this as a new field? Can't we just store this as a constant, and assign?
| @@ -44,7 +53,7 @@ def __init__( | |||
|
|
|||
| @classmethod | |||
| def to_drop(cls: type[M]) -> M: | |||
| return cls(b"", datetime(1, 1, 1, 0, 0), None, [DROP]) | |||
| return cls(b"", Message.event_time_to_drop, None, [DROP]) | |||
There was a problem hiding this comment.
Something like:
Suggested change
| return cls(b"", Message.event_time_to_drop, None, [DROP]) | |
| return cls(b"", EVENT_TIME_TO_DROP, None, [DROP]) |
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
vigith
approved these changes
Oct 13, 2023
ab93
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the event time of messages to drop to epoch(0) - 1ms across all our SDKs.