-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor SDK to split into separate servers #105
Conversation
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
f2e47cb
to
3095b42
Compare
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 97.03% 94.74% -2.30%
==========================================
Files 16 26 +10
Lines 775 1027 +252
Branches 56 69 +13
==========================================
+ Hits 752 973 +221
- Misses 10 31 +21
- Partials 13 23 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
examples/map/even_odd/Makefile
Outdated
@@ -1,6 +1,6 @@ | |||
.PHONY: image | |||
image: | |||
docker build -t "quay.io/numaio/numaflow-python/even-odd:latest" . | |||
docker buildx build -t "quay.io/numaio/numaflow-python/even-odd:v0.5.0" --platform linux/amd64,linux/arm64 . --push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's revert this and stet tag as "0.5.0"
examples/map/even_odd/example.py
Outdated
@@ -22,5 +22,5 @@ def my_handler(keys: list[str], datum: Datum) -> Messages: | |||
|
|||
|
|||
if __name__ == "__main__": | |||
grpc_server = Server(map_handler=my_handler) | |||
grpc_server = Mapper(map_handler=my_handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grpc_server = Mapper(map_handler=my_handler) | |
grpc_server = Mapper(handler=my_handler) |
Signed-off-by: Sidhant Kohli <[email protected]>
Fixes #103