Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor SDK to split into separate servers #105

Merged
merged 10 commits into from
Sep 6, 2023

Conversation

kohlisid
Copy link
Contributor

Fixes #103

Sidhant Kohli added 2 commits September 5, 2023 09:20
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Sidhant Kohli added 3 commits September 5, 2023 09:25
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #105 (7d43e43) into main (b7c130f) will decrease coverage by 2.30%.
The diff coverage is 93.94%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   97.03%   94.74%   -2.30%     
==========================================
  Files          16       26      +10     
  Lines         775     1027     +252     
  Branches       56       69      +13     
==========================================
+ Hits          752      973     +221     
- Misses         10       31      +21     
- Partials       13       23      +10     
Files Changed Coverage Δ
pynumaflow/reducer/asynciter.py 100.00% <ø> (ø)
pynumaflow/reducer/async_server.py 89.89% <89.89%> (ø)
pynumaflow/mapstreamer/async_server.py 90.24% <90.24%> (ø)
pynumaflow/sourcetransformer/_dtypes.py 92.85% <92.85%> (ø)
pynumaflow/mapper/_dtypes.py 93.67% <93.67%> (ø)
pynumaflow/mapstreamer/_dtypes.py 93.75% <93.75%> (ø)
pynumaflow/mapper/server.py 95.23% <95.23%> (ø)
pynumaflow/sourcetransformer/server.py 95.45% <95.45%> (ø)
pynumaflow/mapper/multiproc_server.py 95.55% <95.55%> (ø)
pynumaflow/mapper/async_server.py 95.83% <95.83%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kohlisid kohlisid marked this pull request as ready for review September 5, 2023 16:47
@kohlisid kohlisid requested a review from yhl25 September 5, 2023 16:47
@vigith vigith closed this Sep 5, 2023
@vigith vigith reopened this Sep 5, 2023
Sidhant Kohli added 4 commits September 5, 2023 12:55
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
@@ -1,6 +1,6 @@
.PHONY: image
image:
docker build -t "quay.io/numaio/numaflow-python/even-odd:latest" .
docker buildx build -t "quay.io/numaio/numaflow-python/even-odd:v0.5.0" --platform linux/amd64,linux/arm64 . --push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revert this and stet tag as "0.5.0"

@@ -22,5 +22,5 @@ def my_handler(keys: list[str], datum: Datum) -> Messages:


if __name__ == "__main__":
grpc_server = Server(map_handler=my_handler)
grpc_server = Mapper(map_handler=my_handler)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
grpc_server = Mapper(map_handler=my_handler)
grpc_server = Mapper(handler=my_handler)

Signed-off-by: Sidhant Kohli <[email protected]>
@vigith vigith merged commit 3720c95 into numaproj:main Sep 6, 2023
9 checks passed
@kohlisid kohlisid deleted the sdk-refactor branch October 3, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python SDK Changes
4 participants