feat: implement sdk for session reduce #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
|
Convert to draft mode since it's taking too long to review. |
yhl25
reviewed
Feb 14, 2024
src/main/java/io/numaproj/numaflow/sessionreducer/SessionReducerActor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/sessionreducer/SessionReducerActor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/sessionreducer/SessionReducerActor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
yhl25
reviewed
Mar 12, 2024
Comment on lines
90
to
92
| // set time out to 1 second as we expect a MERGE operation to finish quickly. | ||
| Timeout timeout = new Timeout(Duration.create(1, "seconds")); | ||
| try { |
There was a problem hiding this comment.
Hacky, sometimes it might take more than 1 second
There was a problem hiding this comment.
thanks, what should be the proper number? @yhl25
There was a problem hiding this comment.
let's wait until it returns
There was a problem hiding this comment.
also, please add unit tests to cover merge followed by another operation to make sure the blocking call works!
There was a problem hiding this comment.
The method Await asks for a timeout, I don't think we should wait forever, right? Maybe we should set an atMost timeout value and throws when the operation takes too long.
Yes, the uts for merge are already in place. Please check the serverTest class.
Signed-off-by: Keran Yang <[email protected]>
yhl25
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using the existing golang sdk e2e: KeranYang/numaflow#98