review comments

Signed-off-by: Yashash H L <[email protected]>
numaproj · Oct 8, 2024 · cf96b60 · cf96b60
1 parent 40ec7d3
commit cf96b60
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java b/src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java
@@ -22,6 +22,7 @@
 import java.util.List;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
 
 public class ServerErrTest {
 
@@ -125,6 +126,7 @@ public void testMapperFailure() {
 
         try {
             responseObserver.done.get();
+            fail("Expected exception not thrown");
         } catch (Exception e) {
             assertEquals(
                     "io.grpc.StatusRuntimeException: UNKNOWN: unknown exception",

diff --git a/src/test/java/io/numaproj/numaflow/mapper/ServerTest.java b/src/test/java/io/numaproj/numaflow/mapper/ServerTest.java
@@ -133,6 +133,7 @@ public void testMapperWithoutHandshake() {
 
         try {
             responseObserver.done.get();
+            fail("Expected an exception to be thrown");
         } catch (InterruptedException | ExecutionException e) {
             assertEquals(
                     "io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Handshake request not received",