Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find user endpoint. #59

Conversation

Parth858
Copy link
Contributor

This endpoint retrieves the particular user as per specified in post request body (json)

@@ -696,6 +697,31 @@ def remove_documents(self, request, pk=None):
f"{document_type.capitalize()} removed successfully", status.HTTP_200_OK
)

@action(detail=False, methods=["post"])
def find_user(self, request):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function name should be "retrieve_users"

Comment on lines 716 to 720
if experience:
queryset = queryset.filter(experience=experience)

if location:
queryset = queryset.filter(address__icontains=location)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs refactoring,

if experience is not None:
queryset = queryset.filter(experience=experience)

is not None check for the experience filter, as it could be 0, and a falsy check (if experience:) would not work correctly in that case

Copy link
Collaborator

@hims1911 hims1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested minor changes, @Himan10 @Parth858 please validate

Copy link
Contributor Author

@Parth858 Parth858 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored the code as per the request i.e added is not None check for the experience.

@Himan10 Himan10 merged commit 2b4851a into null-open-security-community:main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants