Find user endpoint. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hims1911
reviewed
Jan 22, 2024
apps/jobs/views.py
Outdated
| @@ -696,6 +697,31 @@ def remove_documents(self, request, pk=None): | |||
| f"{document_type.capitalize()} removed successfully", status.HTTP_200_OK | |||
| ) | |||
|
|
|||
| @action(detail=False, methods=["post"]) | |||
| def find_user(self, request): | |||
There was a problem hiding this comment.
function name should be "retrieve_users"
hims1911
reviewed
Jan 22, 2024
apps/jobs/views.py
Outdated
Comment on lines
716
to
720
| if experience: | ||
| queryset = queryset.filter(experience=experience) | ||
|
|
||
| if location: | ||
| queryset = queryset.filter(address__icontains=location) |
There was a problem hiding this comment.
needs refactoring,
if experience is not None:
queryset = queryset.filter(experience=experience)
is not None check for the experience filter, as it could be 0, and a falsy check (if experience:) would not work correctly in that case
Parth858
commented
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint retrieves the particular user as per specified in post request body (json)