Pagination - I #54
Merged
Pagination - I #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/jobs/views.py
Outdated
Comment on lines
77
to
78
| page_number = request.GET.get("page", 1) | ||
| paginator = Paginator(jobs_data, 5) # 5 items per page |
There was a problem hiding this comment.
Use it from constant, store it in constant.
| @action(detail=False, methods=["get"]) | ||
| def get_posted_jobs(self, request): | ||
| """ | ||
| API: localhost:8000/jobs/get_posted_jobs/ |
Parth858
commented
Jan 15, 2024
| @@ -427,6 +428,54 @@ def get_job_categories(self, request): | |||
| serialized_job_categories, status.HTTP_200_OK | |||
| ) | |||
|
|
|||
| @action(detail=False, methods=["get"]) | |||
| def get_jobs(self, request): | |||
There was a problem hiding this comment.
- Retrive jobs as per quary parameter also jobs where exp <=3.
request: http://localhost:8000/jobs/get_jobs/?category=Security&experience=3
response: { {
"job_id": "beb1b9dc-5106-423c-95e8-efbbc0103d8b",
"job_role": "Security Analysist II",
"location": "Mumbai",
"post_date": "2023-10-11",
"posted": true,
"experience": 0,
"created_at": "2024-01-11T18:07:00.626348Z",
"updated_at": "2024-01-11T18:07:00.626348Z",
"employer_id": "5e1f2925-9deb-492f-8a06-f451daf9310a",
"job_type": "full time",
"salary": "30000.00",
"qualifications": "OWASP",
"vacency_position": 5,
"industry": "IT",
"category": "Security",
"is_active": true,
"company": "d937d8f3-6c54-4bf2-b652-e44597910693",
"description": {
"About": "You will be responsible for designing, developing, testing, and deploying distributed machine learning systems and large-scale solutions for our world-wide customer base",
"Job Responsibilities": "No Job Responsibilities provided",
"Skills Required": "No skills details provided",
"Educations/Certifications": "No Education details provided"
}
},
{
"job_id": "c8fddf51-644e-42a7-8ef1-d91178dbf22d",
"job_role": "Junior Developer",
"location": "Mumbai",
"post_date": "2023-10-11",
"posted": true,
"experience": 3,
"created_at": "2024-01-19T12:41:51.821701Z",
"updated_at": "2024-01-19T12:41:51.829724Z",
"employer_id": "5e1f2925-9deb-492f-8a06-f451daf9310a",
"job_type": "full time",
"salary": "30000.00",
"qualifications": "OWASP",
"vacency_position": 5,
"industry": "IT",
"category": "Security",
"is_active": true,
"company": "d937d8f3-6c54-4bf2-b652-e44597910693",
"description": {
"About": "Manage the group of people as well as make the upcomming task secure.",
"Job Responsibilities": "No Job Responsibilities provided",
"Skills Required": "No skills details provided",
"Educations/Certifications": "No Education details provided"
}
- Dynamically retriving of jobs as per the queary updation
request: http://localhost:8000/jobs/get_jobs/?job_type=full time
response: {
"job_id": "be5f509a-855a-4de8-b13e-7cb6cf2243fc",
"job_role": "Product Manager",
"location": "California",
"post_date": "2023-10-11",
"posted": true,
"experience": 0,
"created_at": "2024-01-11T17:58:36.746918Z",
"updated_at": "2024-01-11T17:58:36.746918Z",
"employer_id": "5e1f2925-9deb-492f-8a06-f451daf9310a",
"job_type": "full time",
"salary": "20000.00",
"qualifications": "Commerces, Data Managment",
...
HimanshuSharma-Angel
approved these changes
Jan 18, 2024
Himan10
requested changes
Jan 18, 2024
| COVER_LETTER_DOCUMENT_TYPE = "cover_letter" | ||
|
|
||
| ITEMS_PER_PAGE = 5 | ||
| PAST_3_WEEK_DATETIME_DAYS18 = 18 |
There was a problem hiding this comment.
change the variable name to something else, something that resembles to the functionality for which we are using it.
There was a problem hiding this comment.
lets not change the name they are as we discussed and as per the functionality.
|
@Parth858 share the latest request/response of the API endpoints present in this PR. |
Parth858
commented
Jan 19, 2024
| @@ -355,6 +368,82 @@ def featured_jobs(self, request): | |||
| response.SOMETHING_WENT_WRONG, status.HTTP_500_INTERNAL_SERVER_ERROR | |||
| ) | |||
|
|
|||
| @action(detail=False, methods=["get"]) | |||
| def get_posted_jobs(self, request): | |||
There was a problem hiding this comment.
(update sample response where per page items are 3 )
request: http://localhost:8000/jobs/get_posted_jobs/?page=2
response: "data": [
{
"job_id": "beb1b9dc-5106-423c-95e8-efbbc0103d8b",
"job_role": "Security Analysist II",
"location": "Mumbai",
"post_date": "2023-10-11",
"posted": true,
"experience": 0,
"created_at": "2024-01-11T18:07:00.626348Z",
"updated_at": "2024-01-11T18:07:00.626348Z",
"employer_id": "5e1f2925-9deb-492f-8a06-f451daf9310a",
"job_type": "full time",
"salary": "30000.00",
"qualifications": "OWASP",
"vacency_position": 5,
"industry": "IT",
"category": "Security",
"is_active": true,
"company": "d937d8f3-6c54-4bf2-b652-e44597910693",
"description": {
"About": "You will be responsible for designing, developing, testing, and deploying distributed machine learning systems and large-scale solutions for our world-wide customer base",
"Job Responsibilities": "No Job Responsibilities provided",
"Skills Required": "No skills details provided",
"Educations/Certifications": "No Education details provided"
},
"Number of Applicants": 0
},
{
"job_id": "c8fddf51-644e-42a7-8ef1-d91178dbf22d",
"job_role": "Junior Developer",
"location": "Mumbai",
"post_date": "2023-10-11",
"posted": true,
"experience": 3,
"created_at": "2024-01-19T12:41:51.821701Z",
"updated_at": "2024-01-19T12:41:51.829724Z",
"employer_id": "5e1f2925-9deb-492f-8a06-f451daf9310a",
"job_type": "full time",
"salary": "30000.00",
"qualifications": "OWASP",
"vacency_position": 5,
"industry": "IT",
"category": "Security",
"is_active": true,
"company": "d937d8f3-6c54-4bf2-b652-e44597910693",
"description": {
"About": "Manage the group of people as well as make the upcomming task secure.",
"Job Responsibilities": "No Job Responsibilities provided",
"Skills Required": "No skills details provided",
"Educations/Certifications": "No Education details provided"
},
"Number of Applicants": 0
},
{
"job_id": "fc52dbad-8a83-4276-99be-a61104234ff9",
"job_role": "Unit Tester",
"location": "California",
"post_date": "2023-10-11",
"posted": true,
"experience": 0,
"created_at": "2024-01-11T18:02:26.112538Z",
"updated_at": "2024-01-11T18:02:26.112538Z",
"employer_id": "5e1f2925-9deb-492f-8a06-f451daf9310a",
"job_type": "full time",
"salary": "20000.00",
"qualifications": "Commerces, Data Managment",
"vacency_position": 3,
"industry": "IT",
"category": "Testing",
"is_active": true,
"company": "b2490ff9-cb56-4627-9653-921051267074",
"description": {
"About": "You will be responsible for designing, developing, testing, and deploying distributed machine learning systems and large-scale solutions for our world-wide customer base",
"Job Responsibilities": "No Job Responsibilities provided",
"Skills Required": "No skills details provided",
"Educations/Certifications": "No Education details provided"
},
"Number of Applicants": 0
}
]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic pagination as per Django documentation for jobs,user list view retrieved per page number of data is 2 (for sample) also added dynamic endpoint filters for get_jobs by category and get posted jobs with pagination.